Solidity-coverage: Investigate if Solidity 0.5.0 will break solidity-coverage

[cgewecke]

One breaking change is the removal of the constant key from the ABI. However it looks like SC will be ok with this, here? We don't really touch the ABI directly.

[NoahHydro]

One breaking change I've found is that in interfaces, marking bytes, string, etc. variables with the required calldata location throws an error. For example, the below throws Expected ")", ",", comment, end of line, or whitespace but "v" found.:

pragma solidity ^0.5.0;

interface MyInterface {
    function myFunction(bytes calldata myBytes);
}

[cgewecke]

Thanks @NoahHydro.

[elenadimitrova]

Breaking on the new address payable syntax as well https://circleci.com/gh/JoinColony/colonyNetwork/5422

[angus-hamill]

https://github.com/sc-forks/solidity-parser/pull/17
Opened a PR for the calldata issue here, runs successfully on my project

[maxsam4]

Breaking on the new address payable syntax as well https://circleci.com/gh/JoinColony/colonyNetwork/5422

https://github.com/sc-forks/solidity-parser/pull/18 This should fix it.
props to @duaraghav8 for original fix.

[cgewecke]

Yes. It did. Fixed in 0.6.0