Solargraph: autocompletion does not work if array given for an object

[gencer]

When I declare type for solargraph and fetch an object from an array, autocompletion does not work. See here:

If I do this by giving a method or a static member then it works:

Basically, anything[] type does not support autocomplete. I cannot see methods in it.

Sample:

    # @type [Reserve]
    source = Reserve[source_id]
    # @type [Reserve]
    another = anonymous_method()

    source. # does not work.
    another. # works.

[gencer]

@castwide, I'm not sure if this and above related to this gem or vscode extension but here is another issue:

[castwide]

In your first screenshot, it looks like def perform lacks an end. Solargraph will attempt to correct for parser errors while the file's being edited, but is sometimes unable to do so. Here are my results with and without a closing end:

If your second screenshot isn't inside an unclosed method definition, that could explain why it works.

The third screenshot might also be due to a similar parser error (if without end), although Solargraph should be able to detect and correct it in most cases:

[gencer]

It is interesting that it work for you.

I had end's already. But i figured it out why it is not working. I had a rescue at bottom. See this GIF:

As you can see, If I have a rescue, if and source. does not work. If I remove rescue part it just works both for if and source.

[castwide]

Thanks for the followup. I was able to reproduce the problem with rescue. I'll work on a fix.

[castwide]

Fortunately, the new source mapper made this relatively simple to fix. rescue nodes work in the master branch. There was a related issue with explicit begin nodes which is also fixed. I'll include the changes in gem version 0.29.0.

[gencer]

I'm happy to hear that and await for the new version.

Thanks!

[gencer]

@castwide, does this fix currently in master?

[castwide]

@gencer It should, yes. I just tested it again on my checkout.

[gencer]

@castwide Just wanted to be sure. Here is another issue:

If you assign a variable and tell solargraph of its type but use with a condition, autocomplete does not work.

Basically:

# @type [Array<Object>]
a = b
a. # <- auto complete works and Object get listed.

---

# @type [Array<Object>]
a = b unless b.nil?
a. # <- autocomplete does not work because we used unless/if.

Update: This can be a little tricky. See, We can use multiple if's for same variable. However, at least the first one should be used. Because whatever I return from a File, Folder or another object, Comments are always have same methods.

[castwide]

Confirmed. It's a minor bug that's also related to the new source mapper. I'll have it fixed in master shortly and will include the fix in v0.29.0.

[gencer]

@castwide one more question. Is there any way to use YARD documentation for attr_'s?

For example:

class User
   # @type [Comment]
   attr_reader :comment
end

user = User.new
user.comment. # <- I expect Comment object methods here but it does not work.

[castwide]

Attributes are kinds of methods, so you should use @return instead of @type.

class User
  # @return [Comment]
  attr_reader :comment
end

[gencer]

@castwide, Gotcha. Sorry for this.

I also send you an e-mail. Sample video + Sample project. There is an issue with autocomplete when nested classes used. You can watch there and test yourself.

Gencer.

[castwide]

@gencer The bug related to your last email is being tracked in #108. The fix is scheduled for release in v0.29.0.

[castwide]

Fix released in v0.29.0.

[gencer]

@castwide, if you get an e-mail (as notification) about this issue, please ignore it. My bad.