Sol2: Can't compile after updating vs2019 to newest version

[xzores]

I get the error:
'function_pointer_type' is not member if "sol::lua_bind:traitsbasic:reference>
in call.hpp line 344

This happened after updating to vs2019 16.6.0

[adam4813]

This is now a problem with github actions as they have moved their Visual Studio version to 16.6. I realize that there was a commit https://github.com/ThePhD/sol2/commit/053a7fdcb13605fbbd2b660325578a75adfbb8f4 that addressed this, but, from my understanding, you don't plan to release for a month or more. Is it possible to do a patch release version that fixes this to allow github actions to continue to work again?

[ThePhD]

Guess I need a quick patch release. Lemme try to split my changes into pieces.

Pray for me: I am bad at git.

[adam4813]

If you can make one, I'll make a pr for vcplg.

[egorpugin]

Also have been hit by this.

[ThePhD]

https://github.com/ThePhD/sol2/releases/tag/v3.2.1

Fire up the CI engines.

[adam4813]

Someone beat me to adding a vcpkg PR, but it is up

[helmesjo]

@ThePhD Could we get this release into conan-center as well? :)

[ThePhD]

Lemme try to figure out what that takes.

[helmesjo]

@ThePhD Thanks! See here for an example PR (for the previous version).

[ThePhD]

Oop, they require I actually run conan and all that jazz on my local machine to verify it works.

I don't have conan or any idea what it takes to get it all set up xD

[helmesjo]

@jgsogo
Hello friend! ☝️ 😇 Could you give some directions and/or help out? 😃

[jgsogo]

Hi! Is this a new version 3.2.1?

Have you tried to create the PR to Conan Center? Adding a new version is really, really easy, just add it to config.yml and to 3.x.x/conandata.yml files in this folder: https://github.com/conan-io/conan-center-index/tree/master/recipes/sol2

Version 3.2.0 is already there so probably it is not required to change anything else in the recipe or the build system.

[ThePhD]

Nonono, I wasn't confused about /how/ to do it, I know what to do given the PRs that others worked so hard on!

I just can't satisfy the checklist of "and you must run it on your computer to check it works", because I don't have conan on my computer yet!

[jgsogo]

You can create the PR with the changes and just have a look to the CI output... I won't punish you for not clicking that checkbox 😅

But don't worry, tomorrow I'll create the PR myself if you didn't before

[ThePhD]

Ahhh you beat me to it! Well, thank you for your help here.

Sometimes, I wish I had less to do. ;;

[jgsogo]

Sometimes, I wish I had less to do. ;;

Same here, but Conan and Conan-related repos is my battlefield. I can move quickly there. 😄

[jgsogo]

Already there 🎉 https://conan.io/center/sol2/3.2.1

conan install sol2/3.2.1@ -g cmake_find_package [--profile <configuration>]

and there you have it, ready to use!

[ThePhD]

Sheeeit, you're fast! Thanks for working on this. 💞