Socket.io-client-swift: Plan to support Starscream v4
I am experiencing many crashes similar to https://github.com/daltoniam/Starscream/issues/588 in my app. The Starscream maintainers claim in this issue that the crash is fixed due to their rewrite and release of version 4.0.0 (https://github.com/daltoniam/Starscream/pull/653).
This major release is incompatible with the current implementation of socket.io-client-swift and will require changes to this library. Additionally, the new version of Starscream is incompatible with Objective-C.
Is there a desire from socket.io-client-swift to upgrade Starscream to 4.0.0?
patmalt
All 19 comments
I鈥檒l look into upgrading
nuclearace
on 3 Jan 2020
I started the effort here: https://github.com/emersonsoftware/socket.io-client-swift/tree/starscream-v4
patmalt
on 3 Jan 2020
@nuclearace Any updates on the plan to support v4?
patmalt
on 3 Feb 2020
@patmalt I haven't had time to look into yet, but I'd welcome a PR to see what it might look like. Otherwise I don't have a specific timeline. Dropping Obj-c support is something that I'd like to avoid if possible, but wouldn't be dealbreaker I guess.
nuclearace
on 3 Feb 2020
Hello!
I'd highly appreciate Starscream v4 support! Any updates so far? :)
NikitaBorodkin
on 28 May 2020
I plan to start working on this this weekend. The big decision needed is whether to continue supporting Obj-C in some fashion, or just abandon that compatibility. I think I'll try to maintain that support, but if it gets too ugly, might have to abandon it.
nuclearace
on 30 May 2020
given the name of this library, it may be appropriate to drop support for objc?
patmalt
on 30 May 2020
I really think it's time to drop Obj-C support! :)
NikitaBorodkin
on 30 May 2020
Is there any word on when this will be released?
cyambo-talkspace
on 12 Jun 2020
Is there any way the community could assist with the effort?
patmalt
on 12 Jun 2020
We are getting a significant number of crashes from Starscream v3, and would really appreciate if the library could be updated to use v4. Is there any update on if or when that will happen?
lseidman-talkspace
on 25 Jun 2020
Has there been any progress on this? Is there any way the community can help get us to v4?
patmalt
on 22 Jul 2020
Hi, I am also experiencing the same crashes with Starscream and eagerly await the update to include v4, would love to know progress. Do let us know if the community can contribute :)
morithil
on 27 Jul 2020
I've been doing some exploration. I've come to the conclusion that the next version of the library will be dropping support for Objective-C. This will allow for a simpler lib and hopefully allow for more swiftier style API.
nuclearace
on 27 Jul 2020
I have a working implementation here: https://github.com/emersonsoftware/socket.io-client-swift/tree/v4
There are somethings I just commented out that need lots of work. I have not run this code in production either.
patmalt
on 27 Jul 2020
Is there any plan for the next version that will use the newer version of Starscream?
congnd
on 26 Aug 2020
Support Starscream v4
DHCC-DH
on 11 Sep 2020
Hi @nuclearace , any updates on Starscream v4 support?
morithil
on 2 Nov 2020
nuclearace
on 7 Nov 2020
Related issues
gaetanm
路
4Comments
MihaelIsaev
路
6Comments
Dohab
路
4Comments
jetricy
路
5Comments
njawahire
路
4Comments
Most helpful comment
I plan to start working on this this weekend. The big decision needed is whether to continue supporting Obj-C in some fashion, or just abandon that compatibility. I think I'll try to maintain that support, but if it gets too ugly, might have to abandon it.