Social: Send an "Accept" as answer to a "Follow"

Created on 17 Dec 2018  路  16Comments  路  Source: nextcloud/social

Currently contact requests from Friendica aren't shown as "accepted" on the Friendica side. This is related to the fact that Friendica awaits an "Accept Follow" message. This message is sent by most known implementations.

See here for details: https://w3c.github.io/activitypub/#follow-activity-inbox

enhancement needs info

Most helpful comment

I now was able to test it. This seems to work great.

All 16 comments

We do Accept on Follow request. I will have a look on why it's not working with Friendica

This is the request I am sending back to you when I am receiving your request:

host: squeet.me
path: /inbox/cult
type: POST,
result: : 202

{
    "@context": [
      "https://www.w3.org/ns/activitystreams",
      "https://w3id.org/security/v1"
    ],
    "id": "https://test.artificial-owl.com/apps/social/@test1#accepts/follows/93dfde98-ff5a-4bc7-8019-a9e8bds01b25",
    "type": "Accept",
    "actor": "https://test.artificial-owl.com/apps/social/@test1",
    "object": {
      "id": "https://squeet.me/activity/9625c194757e06b1",
      "type": "Follow",
      "actor": "https://squeet.me/profile/cult",
      "object": "https://test.artificial-owl.com/apps/social/@test1"
    }
}

Currently I cannot test it by myself, I'm still waiting for the updater telling me that there is a new version. On a first glance - and by looking into the logfile this looks okay.

Sorry for the false alarm.

no problem, glad we can check on this together!

@annando, you can force an upgrade to 15 by

  • opening the Admin Settings/Overview page,
  • selecting the update channel to 'beta',
  • refresh the page,
  • switch back to 'production'

You should see the NC15 update available

This is my production system with valuable data on it - is it safe?

We鈥檙e not in a rush here, maybe it鈥檚 just best to wait out until the update gets suggested to you. Sometimes takes a bit longer since we do this rollout in stages, and also you might want to wait for the first dot-release with fixes and such.

Okay. If that's fine for you, then it's fine for me.

Using Nextcloud 15.0.0.10 and Social 0.1.1 this also occurs for a Mastodon 2.6.5 instance. The follow is listed in Social but the Mastodon instance states an approval is required.

image

Also no updates from the Social account are shown on the Mastodon instance and the profile isn't loaded properly (lacking image, way too high follower count) but this might be another unreleated issue.

@annando so I dived into friendica, and it seems that the normalization of the object is different/buggy.

Is https://git.friendi.ca/friendica/php-json-ld/src/branch/master/jsonld.php a fixed version of the original from digitalbazaar ?

(Source:
https://github.com/friendica/friendica/blob/491fc5f78aadb787a57a0f0630779f457ff1bcb4/src/Util/LDSignature.php#L86-L89, https://github.com/friendica/friendica/blob/491fc5f78aadb787a57a0f0630779f457ff1bcb4/src/Util/JsonLD.php#L58-L73)

We fixed issue https://github.com/digitalbazaar/php-json-ld/issues/6 in our own repository since the original repository seems to be abandoned.

ok, i will try with your package of ld-json, seems to work better.

0.1.2 should have fixed this. Please confirm

I cannot do tests by myself, since the updater still don't offer me an update and I don't want to switch to the beta channel, since my NC installation contains valuable data.

I now was able to test it. This seems to work great.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jancborchardt picture jancborchardt  路  6Comments

maiki picture maiki  路  5Comments

ArtificialOwl picture ArtificialOwl  路  7Comments

sunjam picture sunjam  路  4Comments

jancborchardt picture jancborchardt  路  5Comments