Snowpack: Help wanted: create tests for internal plugins

Created on 9 Sep 2020  ·  21Comments  ·  Source: snowpackjs/snowpack

Original Discussion: https://github.com/pikapkg/snowpack/discussions/958#discussioncomment-72307
/cc @FredKSchott @drwpow @ralphtheninja

Snowpack's internal plugins do not currently have good test coverage. We would like to change that 😄

If anyone would like to contribute to Snowpack, comment which one of the plugins below you would like to claim, and create tests similar to what @Akimyou did in https://github.com/pikapkg/snowpack/pull/984. The tests do not need to be complete, we can iterate. Few tests are better than none :)

  • [x] [babel-plugin-package-import](https://github.com/pikapkg/snowpack/tree/master/plugins/babel-plugin-package-import)
  • [x] [plugin-babel](https://github.com/pikapkg/snowpack/tree/master/plugins/plugin-babel) (@JennieJi #1097 #1199)
  • [x] [plugin-build-script](https://github.com/pikapkg/snowpack/tree/master/plugins/plugin-build-script) (@gr2m #1301)
  • [x] [plugin-dotenv](https://github.com/pikapkg/snowpack/tree/master/plugins/plugin-dotenv) (@MoonBall #1087)
  • [x] [plugin-optimize](https://github.com/pikapkg/snowpack/tree/master/plugins/plugin-optimize) (@gr2m #1300)
  • [X] ~plugin-parcel~ No longer supported
  • [ ] [plugin-postcss](https://github.com/pikapkg/snowpack/tree/master/plugins/plugin-postcss) (claimed by @thescripted https://github.com/pikapkg/snowpack/issues/1019#issuecomment-704401873)
  • [x] [plugin-react-refresh](https://github.com/pikapkg/snowpack/tree/master/plugins/plugin-react-refresh) (@MoonBall https://github.com/snowpackjs/snowpack/pull/1319)
  • [X] [plugin-run-script](https://github.com/pikapkg/snowpack/tree/master/plugins/plugin-run-script) (claimed by @FredKSchott https://github.com/pikapkg/snowpack/issues/1019#issuecomment-695882081)
  • [x] [plugin-svelte](https://github.com/pikapkg/snowpack/tree/master/plugins/plugin-svelte) (#1241)
  • [x] [plugin-vue](https://github.com/pikapkg/snowpack/tree/master/plugins/plugin-vue) (#984)
  • [x] [plugin-webpack](https://github.com/pikapkg/snowpack/tree/master/plugins/plugin-webpack) (claimed by @gr2m, #1061)

Once all plugins are tested, close issue and update https://github.com/pikapkg/snowpack/discussions/958#discussioncomment-72307

help wanted

All 21 comments

I would like to add test for plugin-webpack.

Edit: @ralphtheninja started this work in https://github.com/pikapkg/snowpack/issues/1012#issuecomment-689182988. So I will contribute to plugin-dotenv.

@ralphtheninja just to confirm, are you working on test for plugin-webpack?

@gr2m Nope, I never got started on it.

no worries, @MoonBall would you like to work on it? If not I'd do it myself, I think it's the most important one to have tests right now

@gr2m I started plugin-dotenv. So you do it.

Hi @gr2m I would like to try plugin-babel

Hi @JennieJi, I've signed you up. Thanks for looking into it 👍🏼

@gr2m I would like to work on plugin-react-refresh.

You got it, thank you!

Woo! This is exciting to see! @gr2m got one that I can take a look at? Maybe plugin-run-script & plugin-build-script?

Sure, just update the issue description for the one you are working on

I feel pretty comfortable working on tests for plugin-postcss

Great, all yours @thescripted!

Just added a test for plugin-svelte in #1241!

@MoonBall just checking in, no rush: are you still working on / planning to work on plugin-react-refresh?

I'll work on the last unclaimed one: plugin-optimize.

Wonderful to see this all come together, thanks a bunch everyone 💐

actually plugin-build-script is up for grabs again ☝🏼

Yup, anyone feel free to grab it! It should be pretty similar to the run-script tests

I'm looking into plugin-build-script myself now

I'll close the issue it's no longer actionable for people looking to contribut.

@thescripted @MoonBall let us know in case you won't be able to submit pull requests for the respective tests

woo! awesome job driving this @gr2m!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

FredKSchott picture FredKSchott  ·  6Comments

FredKSchott picture FredKSchott  ·  5Comments

FredKSchott picture FredKSchott  ·  6Comments

FredKSchott picture FredKSchott  ·  4Comments

daniele-orlando picture daniele-orlando  ·  6Comments