Describe the bug
Unable to save LDAP settings page "/admin/ldap"
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Expected settings to be saved or meaningful error displayed
Server (please complete the following information):
Desktop (please complete the following information):
Error Messages
snipe LDAP error.txt
Can not reproduce on Demo as LDAP page is restricted
Additional context
problem is on file app/Http/Controllers/SettingsController.php row 868
Latest commit was
it should have been
- if (Input::has('ldap_pword')) {
+ if (Input::filled('ldap_pword')) {
changing that fixed it for me
Thanks, this fixed it for me!
@Jonkke83 Thanks, that was the issue all happy now.
Good eye @Jonkke83! Thank you for pointing that out!
confirmed
On Mon, Jun 17, 2019, 5:25 AM phsmichael notifications@github.com wrote:
Please confirm you have done the following before posting your bug report:
- I have enabled debug mode
- I have read checked the Common Issues page
https://snipe-it.readme.io/docs/common-issuesDescribe the bug
Unable to save LDAP settings page "/admin/ldap"To Reproduce
Steps to reproduce the behavior:
- Browse to /admin/ldap
- Do not make any changes to the page
- Click save
Expected behavior
Expected settings to be saved or meaningful error displayedServer (please complete the following information):
- Snipe-IT Version; v4.7.4 build 4107 (g49a255c8f)
- OS: Ubuntu 18.04.2 LTS (GNU/Linux 4.15.0-51-generic x86_64)
- Web Server: Apache/2.4.29
- PHP Version: 7.2.19-0ubuntu0.18.04.1
- Composer version 1.8.6 2019-06-11 15:03:05
- Laravel version: 5.5.45
Desktop (please complete the following information):
- OS: Windows 10
- Browser: FireFox Version: 67.0.1 (64-bit)
Error Messages
snipe LDAP error.txt
https://github.com/snipe/snipe-it/files/3295017/snipe.LDAP.error.txtCan not reproduce on Demo as LDAP page is restricted
Additional context
- Is this a fresh install or an upgrade? Yes.
- What method you used to install Snipe-IT? install.sh
- Indicate whether or not you've manually edited any data directly in
the database? No database fields have been modified—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/snipe/snipe-it/issues/7169?email_source=notifications&email_token=ABWXRVFVVWUIA7TGPIIKHR3P23YX5A5CNFSM4HYSUIMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GZY5CBA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABWXRVF7AQHSYUGRW4A7GDLP23YX5ANCNFSM4HYSUIMA
.
Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!
This issue has been automatically closed because it has not had recent activity. If you believe this is still an issue, please confirm that this issue is still happening in the most recent version of Snipe-IT and reply to this thread to re-open it.
Most helpful comment
problem is on file app/Http/Controllers/SettingsController.php row 868
Latest commit was
it should have been
- if (Input::has('ldap_pword')) {
+ if (Input::filled('ldap_pword')) {
changing that fixed it for me