Smokedetector: Exclude SmokeDetector itself from !!/blame

Created on 12 Jun 2018  路  4Comments  路  Source: Charcoal-SE/SmokeDetector

It happened again: someone ran the !!/blame command and Smokey blamed itself.

The blame command is supposed to find real, normal users. As such, please prevent SmokeDetector from choosing itself as one of the blame targets.

Most helpful comment

I really don't think this is necessary. !!/blame is a joke command; why is it any less "funny" if it blames itself, and why is this worth changing?

All 4 comments

I really don't think this is necessary. !!/blame is a joke command; why is it any less "funny" if it blames itself, and why is this worth changing?

See also Channels:

The situation with extensions to existing commands is slightly different. If there's a bug in one of them, fixes for that are always welcome. If you're doing a major refactor or new feature and you happen to accidentally extend a fun command too, it'll probably be overlooked. Beyond that, though, pull requests or issues requesting extensions to existing commands are also likely to be declined.

@superplane39 It's not an extension to a fun command. It's a request to remove a feature from an existing fun command.

Playing the semantics game with a bunch of programmers is not going to go very far, I'm afraid. Removing a characteristic of a command requires more code - that much should be obvious to you - so it's an extension.

More generally - with fun commands, the situation is essentially "ignore them unless they're bugged".

Was this page helpful?
0 / 5 - 0 ratings

Related issues

spacemonaut picture spacemonaut  路  5Comments

tripleee picture tripleee  路  3Comments

tripleee picture tripleee  路  7Comments

angussidney picture angussidney  路  9Comments

user12986714 picture user12986714  路  7Comments