Smokedetector: Don’t delete false-positive chat messages in Charcoal HQ

[j-f1]

Currently, if you feedback f to a message from Charcoal HQ, it is deleted. This should not happen.

[teward]

This is currently a by-design item, are you saying you want to change this so it doesn't delete the message from CHQ?

[Undo1]

Actually, we tried a while back to prevent messages from being deleted in CHQ. It regressed at some point (or never worked in the first place).

[teward]

This should be fixed as a result of a recent commit. We now compare the integer values of the Room ID for a given message, and the Room ID of CHQ, and if they are not equal delete.

We previously had not object == object comparison which isn't guaranteed to be identical, and the 'not' may not have been in the right place. The IDs, however, are always going to be something we can compare on though, so we now compare on if int(msg.room.id) != int(GlobalVars.charcoal_hq.id): which is a better check of inequality, but also checks values that we can almost guarantee are reliably comparable. This was tested on Overlord with a debugger to make sure things are processing as expected, but we also now have it on Aurora, and it's working as it should