Smf2.1: Private Message sent via Warning system has no recipient when replying
Description
A user that receives a warning can reply to the warning Private Message.
However, no recipient is auto-populated.
If a Warning PM purposely has no recipient, it shouldn't be made possible to reply. Otherwise, SMF should populate an admin/moderator user or group (of choice?) as recipient.
Steps to reproduce
- Create warning for user
- Log in as user and view PM warning
- "Reply with quote"
- Type reply and send -> Results in "no recipient" error
Environment (complete as necessary)
- Version/Git revision: 2.1 beta 3 - git clone from 21/12/2018
- Database Type: MySQL
- Database Version: 5.7.14
- PHP Version: 7.0.10
Additional information/references
shnazzle
All 25 comments
It should probably be sent from whoever issued the warning
Oldiesmann
on 24 Dec 2018
This has always been the case, though. Warnings were always sent (intentionally) anonymously, by sending a PM without a sender. Maybe simpler to remove the reply option there.
Arantor
on 25 Dec 2018
I do think that's the easiest solution too.
frandominguez03
on 25 Dec 2018
It shouldn't really reveal who sent the warning, yet I think we should allow replying to it.
The way it is now is a good compromise, in most cases users should be able to name an admin or moderator they want to approach on the issue.
LexArma
on 27 Dec 2018
Agreed it should not reveal the actual sender. Maybe the very easiest thing would be to prepopulate with the webmaster email address. This is a stored (global?) value anyway.
shnazzle
on 27 Dec 2018
Repopulating with webmaster email doesn't work - because this is a PM, not an email, so you can't reply to it in that sense.
Replying to this is actually not a simple task because there's no recipient, so you need to have some other way to work out if the message can be replied to, and funnel it somewhere else, and make sure the relevant moderators can see it and action it. Lot of work, that.
Or, just hide the reply button and leave it be able to be reported (which does offer the option of choice of admin).
Arantor
on 27 Dec 2018
I think the most intuitive way would be for there to be a check to see if the sender is the forum. If so, disable the reply. Then in the message itself, admins can choose to put a message in to tell the person to message the admin or a moderator group of choice.
shnazzle
on 27 Dec 2018
I think that was what I suggested ;)
Arantor
on 27 Dec 2018
We agree then haha
Now someone kindly go forth and implement. Don't make me get my code on
shnazzle
on 27 Dec 2018
More likely to get fixed if everyone contributes a little bit :)
Arantor
on 27 Dec 2018
Just forked to fix and noticed that the behaviour is actually different between the Warning notifications and "normal" PMs. With a normal PM, the "Reply" button is shown. With notifications this button isn't shown (seems someone has thought of this before), but the "Reply with quote" button is shown. So I guess just a case of disabling that as well
shnazzle
on 28 Dec 2018
What about if the reporting is disabled. I think the quote button was there originally to allow for easy forwarding. Now if we remove it, and reporting is disabled, it will be a bit more difficult.
LexArma
on 31 Dec 2018
Is reporting disabled based on that change? It only disables the showing of the reply button. Reporting should still be possible
shnazzle
on 31 Dec 2018
No, that does not change reporting - but reporting of PMs is a forum wide setting. Not every install will allow it.
LexArma
on 31 Dec 2018
In any case, the fix I proposed (https://github.com/SimpleMachines/SMF2.1/commit/1714d7980eb6d812dbf7147493dd4e5539dcce9f ) should be OK. If reporting is turned off forum-wide, it's up to the admin to take the queue from the sample template to tell users to message the admin if they need to. The only thing I would say about the fix is that I'd prefer not to use a magic number like 0,inztead of ['member'] ['is_admin'] which doesn't seem to exist there
shnazzle
on 31 Dec 2018
Actually that fix makes more sense because there can be other cases where a PM can be in the system without a valid recipient like that, not just warnings.
Arantor
on 1 Jan 2019
Well yeah, it works, and the addition to the warning template is good too. Not a big problem to lose the quote button.
LexArma
on 2 Jan 2019
@shnazzle - were you going to submit this PR? Just checking!
sbulen
on 8 Sep 2019
frandominguez03
on 8 Sep 2019
@frandominguez03 #5267 is this issue, not a PR.
The PR mentioned above is still in shnazzle's private repo, and has not been submitted.
There are several similar items out there - where folks have applied "Has fix" labels, but there is no PR yet submitted that I can find.
sbulen
on 8 Sep 2019
then we should remove the has fix label from this PR?
illori
on 15 Sep 2019
Hmm... I.must have done something wrong then as I put in a request yonks ago for my code to be merged in.
I put it in here. As per post above https://github.com/SimpleMachines/SMF2.1/commit/1714d7980eb6d812dbf7147493dd4e5539dcce9f
shnazzle
on 15 Sep 2019
a warning should be discussed IMO with the moderators before going to the admin. i would suggest that change be made to the language string.
illori
on 15 Sep 2019
I'm not so sure about that. I'd say a user that wants to argue a moderator action would more often be directed to contact the admin. Also what if the forum has no moderators, a forum always has an admin? I'd say either stick with admin, or replace it with something more neutral like forum staff.
LexArma
on 16 Sep 2019
PR #5297
sbulen
on 17 Sep 2019
Related issues
jdarwood007
路
5Comments
sbulen
路
10Comments
Kindred-999
路
5Comments
lurkalot
路
8Comments
Arantor
路
4Comments
Most helpful comment
This has always been the case, though. Warnings were always sent (intentionally) anonymously, by sending a PM without a sender. Maybe simpler to remove the reply option there.