Slick: 1.9 introduces a breaking change

[hypeJunction]

1.9 just got pulled into my libraries, as I only contrain by minor version, but it looks like the slides are now wrapped with an extra div, so my handlers stopped working. Perhaps you should have released as 2.0?

[hypeJunction]

I am confused. I don't see the 1.9 tag on github, but it's still getting pulled from npm.

[vastra]

I'm also getting this, the extra div is breaking all of my existing styles relying on .originalClass.slick-slide to enable carousel styles and disable pre-carousel loading styles.

[freshman20]

Yes, this is why the 'slick' option doesn't work anymore https://github.com/kenwheeler/slick/issues/3390

[robations]

Hmm, 1.9.0 doesn't seem to have been published on npm yet:

https://www.npmjs.com/package/slick-carousel

and as @hypeJunction mentioned there doesn't seem to be a tag in Github.

[vastra]

I've managed to work around this and the new elements actually end up providing more flexibility. I had to shift my selectors around a bit but basically now use .originalClass for pre-carousel styling, then switch to post-carousel styling with .originalClass.slick-slide-inner-content after making the following modification to slick.js (not ideal but my deadline is tomorrow):

for(b = 0; b < _.options.rows; b++) {
    var row = document.createElement('div');
    row.className = "slick-slide-inner";
    for(c = 0; c < _.options.slidesPerRow; c++) {
        var target = (a * slidesPerSection + ((b * _.options.slidesPerRow) + c));
        var originalSlide = originalSlides.get(target);
        if (originalSlide) {
            if (!~originalSlide.className.indexOf('slick-slide-inner-content')) {
                originalSlide.className += ' slick-slide-inner-content';
            }
            row.appendChild(originalSlide);
        }
    }
    slide.appendChild(row);
}

[anteksiler]

Hi there, I think this needs to be integrated in a minor update.

[hypeJunction]

Hi there, I think this needs to be integrated in a minor update.

Semver does not allow breaking changes in minor releases. Unless the project specifically defines what is covered by the backwards compatibility policy and excludes DOM structure from BC breaks, which I think would be a mistake in case of a plugin that relies on specific DOM structure to function.

[anteksiler]

Did you even read the OP?

[c2-erogers]

@hypeJunction - Add rows: 0 to your init to get rid of the extra <div>.