Slate: Cannot focus inline void elements

[knpwrs]

Do you want to request a _feature_ or report a _bug_?

_bug_

What's the current behavior?

When arrowing through the text in the mentions example, as soon as a mention is highlighted, focus is lost and user can no longer use arrow keys.

Slate: 0.57.1
Browser: Chrome
OS: Mac

What's the expected behavior?

The mentions should become highlighted and arrow keys should continue to work.

[CameronAckermanSEL]

I think this is related to one of the PRs I merged in that was attempting to fix inputs in void nodes.

[dalevy]

Is this related to Issue #2685 and #2019 ?

[cj1128]

Examples with input, editable-voids and embeds are all broken now, You just can't type anything in this input element.

Slate version: 0.57.1

[CameronAckermanSEL]

Hi @cj1128 , the examples that are currently hosted should have functional input voids. Please double check and let me know if that's not the case. The live examples work for me in FF and Chrome.

A version of slate that fixes the problem with the input voids has not yet been released.

[dalevy]

Hi @cj1128 , the examples that are currently hosted should have functional input voids. Please double check and let me know if that's not the case. The live examples work for me in FF and Chrome.

A version of slate that fixes the problem with the input voids has not yet been released.

By any chance, do you have a timeline for the release of the fix @CameronAckermanSEL ?

[kilrain]

Does anyone know if there is a previous version I can rollback to in the meantime where this bug is not present?

[CameronAckermanSEL]

Hey @kilrain, the version of the library that has this bug should not have been released yet, it should only impact the live examples right now. Are you able to reproduce this on the latest release in npm?

[kilrain]

Ah - that's good news. I'm in the middle of upgrading from .47 and haven't yet migrated the inline-void parts of my codebase. Thanks for the quick response @CameronAckermanSEL !

[cj1128]

Hi @cj1128 , the examples that are currently hosted should have functional input voids. Please double check and let me know if that's not the case. The live examples work for me in FF and Chrome.

A version of slate that fixes the problem with the input voids has not yet been released.

Hi @CameronAckermanSEL, this is my bad. I used the release version (0.57.1) to test the master examples. All the examples work well except editable-voids and embeds. I retest them using the master version and they work as expected.

Thanks for all the hard work.

[nahumzs]

@cj1128 I'm using 0.57.1 version on my local development and input on void element don't work, the onChange event doesn't fire and the left and right arrows don't work.

You mention you fixed this with the master version, what version is that?

Thank you for this awesome library btw.

[CameronAckermanSEL]

I think I fixed this problem here. https://github.com/ianstormtaylor/slate/pull/3572

There's a preview deployment under the automated PR checks. Would appreciate a (careful!) second glance