Slate: Examples/code-highlighting error

Created on 5 Sep 2018  Â·  5Comments  Â·  Source: ianstormtaylor/slate

Do you want to request a _feature_ or report a _bug_?

examples bug

https://github.com/ianstormtaylor/slate/tree/master/examples/code-highlighting

What's the current behavior?

Enter 1 and press Enter to repeat this fast
image
image

What's the expected behavior?

No error

Most helpful comment

Looks like there is an issue with the way the decoration is made on line 228-236. The anchor and focus values aren't getting their paths assigned. So, when the paths are compared later down the line the value is null. I'll try to put together a pull request later this afternoon.

All 5 comments

@An0nymous0 Can you please add browser info and more detailed steps? I'm having trouble reproducing this issue.

@ericedem Chrome 69.0.3497.81

Reproduce video:http://recordit.co/mB8tksVg5A

Looks like there is an issue with the way the decoration is made on line 228-236. The anchor and focus values aren't getting their paths assigned. So, when the paths are compared later down the line the value is null. I'll try to put together a pull request later this afternoon.

2319 has a more definitive fix.

Closing in favor of #2319.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

YurkaninRyan picture YurkaninRyan  Â·  3Comments

gorillatron picture gorillatron  Â·  3Comments

JSH3R0 picture JSH3R0  Â·  3Comments

chrpeter picture chrpeter  Â·  3Comments

ianstormtaylor picture ianstormtaylor  Â·  3Comments