Slate: Bug: insert value to an empty table cell does not work

[amitm02]

What's the current behavior?

In the table demo link, it is impossible to write a value to a table cell if the cell is empty

[schneidmaster]

Thanks for the report, I can reproduce this as well (macOS/Chrome 64)

[zhujinxuan]

The bug is caused by

  onKeyDown = (event, change) => {
    const { value } = change
    const { document, selection } = value
    const { startKey } = selection
    const startNode = document.getDescendant(startKey)

    if (selection.isAtStartOf(startNode)) {
      const previous = document.getPreviousText(startNode.key)
      const prevBlock = document.getClosestBlock(previous.key)

      if (prevBlock.type == 'table-cell') {
        event.preventDefault()
        return true
      }
    }

Where

      if (prevBlock.type == 'table-cell') {
        event.preventDefault()
        return true
      }

disable the text insert;

I think we shall only disable delete operations; or at least pass the insert operations

[schneidmaster]

Yeah I agree, that seems to be correct. Looks like it's only a problem with the example implementation and not with slate itself. @zhujinxuan want to send a PR fixing that?

[zhujinxuan]

@schneidmaster Yes, give me some minutes~

[zhujinxuan]

A bug happens when insert at start:
Strangely, the text is bolded

[schneidmaster]

Hmm, looks like it's carrying over the bold mark from the previous cell? (Maybe due to #1561)

[zhujinxuan]

Let us fix it after https://github.com/ianstormtaylor/slate/issues/1561

I think perhaps there is a bug of carrying mark in selection normalization.

[zhujinxuan]

We can fix that after https://github.com/ianstormtaylor/slate/pull/1645

[amitm02]

Any updates regarding this bug?

[zhujinxuan]

@amitm02 Oh, I forgot that. I will submit a PR in this week.