Slate: Select all + paste results in an error when there is a trailing empty block

Created on 5 Dec 2017 · 8Comments · Source: ianstormtaylor/slate

Do you want to request a feature or report a bug?

Bug

What's the current behavior?

If there is a trailing empty block, and we select all with cmd+a and then paste anything, an error occurs:

Uncaught TypeError: Cannot read property 'key' of undefined
    at Changes.insertFragmentAtRange (https://npmcdn.com/[email protected]/dist/slate.js:7158:55)
    at Change.call (https://npmcdn.com/[email protected]/dist/slate.js:10521:10)
    at Change.(anonymous function) [as insertFragmentAtRange] (https://npmcdn.com/[email protected]/dist/slate.js:10580:15)
    at Changes.insertFragment (https://npmcdn.com/[email protected]/dist/slate.js:6193:10)
    at Change.call (https://npmcdn.com/[email protected]/dist/slate.js:10521:10)
    at Change.(anonymous function) [as insertFragment] (https://npmcdn.com/[email protected]/dist/slate.js:10580:15)
    at Object.onPaste (https://npmcdn.com/[email protected]/dist/slate-react.js:11554:14)
    at Stack.run (https://npmcdn.com/[email protected]/dist/slate.js:16879:38)
    at https://npmcdn.com/[email protected]/dist/slate-react.js:9290:20
    at Change.call (https://npmcdn.com/[email protected]/dist/slate.js:10521:10)

Issue can be reproduced on the default fiddle: https://jsfiddle.net/fj9dvhom/1/
Here is a gif: https://imgur.com/a/1KENt

Chrome version 62, Ubuntu 17, Slate version 0.31.5

What's the expected behavior?

After selecting all with cmd+a, paste should work correctly no matter if there is a trailing empty block or not.

bug

Source

optimistiks

👍2

Most helpful comment

No, sorry if I confused things here. This was recently fixed for when inserting text (i.e. for insertTextAtRange), but it's still an issue for insertFragmentAtRange.

tobiasandersen on 11 Dec 2017

👍3

All 8 comments

I did a PR for this. It did solve it in my case.

zGrav on 5 Dec 2017

It's not only when pasting though. If you select all, with a trailing empty block, and type something you also get an error. I think @zGrav's fix will solve the pasting issue, but not for when inserting text.

tobiasandersen on 6 Dec 2017

I do not suffer from this issue @tobiasandersen

zGrav on 6 Dec 2017

Oh you're right, I hand't pulled latest, so I guess it was fixed recently :)

tobiasandersen on 6 Dec 2017

I did found out another one though, PR'ing :)

zGrav on 6 Dec 2017

👍1

So is this fixed on the latest?

ianstormtaylor on 11 Dec 2017

No, sorry if I confused things here. This was recently fixed for when inserting text (i.e. for insertTextAtRange), but it's still an issue for insertFragmentAtRange.

tobiasandersen on 11 Dec 2017

👍3

I think this is fixed in the latest version of Slate.

ianstormtaylor on 8 Aug 2018

Was this page helpful?

0 / 5 - 0 ratings