Slate: state.decorations don't update when operations are applied
Do you want to request a feature or report a bug?
bug
What's the current behavior?
In the highlight example, type a word in the search box, then delete that word (or change it slightly) in the paragraph. The highlight will still be visible applied to the wrong characters.
What's the expected behavior?
The highlight should be removed if the text changes. I think only a minor tweak to the onInputChange method is needed. When I have some extra time this week I can look into it.
twobit
All 5 comments
Ah good call. Actually if we just extracted the body of onInputChange out into an updateDecorators method, and called it from both onInputChange and onChange, I think that would fix it.
ianstormtaylor
on 26 Oct 2017
I just realized...
This is due to state.decorations not being updated in the same way that state.selection is updated in ./operations/apply.js. Every time an operation is applied, the logic checks to see if the selection range needs to be shifted/removed based on what was inserted/removed. If the same thing happened for decorations this would be fixed.
I think we should fix it at the source, instead of in the example.
ianstormtaylor
on 15 Nov 2017
@ianstormtaylor any update on this bug?
roundrobin
on 8 Mar 2018
Not from me personally, because I’m not affected by it right now. But if anyone else wanted to PR a fix that would be awesome!
ianstormtaylor
on 10 Mar 2018
This is fixed in the latest versions of Slate.
ianstormtaylor
on 8 Aug 2018
Related issues
JSH3R0
·
3Comments
ianstormtaylor
·
3Comments
bengotow
·
3Comments
chrpeter
·
3Comments
vdms
·
3Comments
Most helpful comment
I just realized...
This is due to
state.decorationsnot being updated in the same way thatstate.selectionis updated in./operations/apply.js. Every time an operation is applied, the logic checks to see if the selection range needs to be shifted/removed based on what was inserted/removed. If the same thing happened for decorations this would be fixed.I think we should fix it at the source, instead of in the example.