Upgrading from 0.21.x to 0.22.14
The element I'm passing looks as follows:
accessKey:""
align:""
assignedSlot:null
attributes:NamedNodeMap
baseURI:null
childElementCount:0
childNodes:NodeList[1]
children:HTMLCollection[0]
classList:DOMTokenList[0]
className:""
clientHeight:0
clientLeft:0
clientTop:0
clientWidth:0
contentEditable:"inherit"
dataset:DOMStringMap
dir:""
draggable:false
firstChild:text
firstElementChild:null
hidden:false
id:""
innerHTML:"Some text"
innerText:"Some text"
isConnected:true
isContentEditable:false
lang:""
lastChild:text
lastElementChild:null
localName:"h1"
namespaceURI:"http://www.w3.org/1999/xhtml"
nextElementSibling:p
nextSibling:p
nodeName:"H1"
nodeType:1
nodeValue:null
offsetHeight:0
offsetLeft:0
offsetParent:null
offsetTop:0
offsetWidth:0
onabort:null
onauxclick:null
onbeforecopy:null
onbeforecut:null
onbeforepaste:null
onblur:null
oncancel:null
oncanplay:null
oncanplaythrough:null
onchange:null
onclick:null
onclose:null
oncontextmenu:null
oncopy:null
oncuechange:null
oncut:null
ondblclick:null
ondrag:null
ondragend:null
ondragenter:null
ondragleave:null
ondragover:null
ondragstart:null
ondrop:null
ondurationchange:null
onemptied:null
onended:null
onerror:null
onfocus:null
ongotpointercapture:null
oninput:null
oninvalid:null
onkeydown:null
onkeypress:null
onkeyup:null
onload:null
onloadeddata:null
onloadedmetadata:null
onloadstart:null
onlostpointercapture:null
onmousedown:null
onmouseenter:null
onmouseleave:null
onmousemove:null
onmouseout:null
onmouseover:null
onmouseup:null
onmousewheel:null
onpaste:null
onpause:null
onplay:null
onplaying:null
onpointercancel:null
onpointerdown:null
onpointerenter:null
onpointerleave:null
onpointermove:null
onpointerout:null
onpointerover:null
onpointerup:null
onprogress:null
onratechange:null
onreset:null
onresize:null
onscroll:null
onsearch:null
onseeked:null
onseeking:null
onselect:null
onselectstart:null
onshow:null
onstalled:null
onsubmit:null
onsuspend:null
ontimeupdate:null
ontoggle:null
onvolumechange:null
onwaiting:null
onwebkitfullscreenchange:null
onwebkitfullscreenerror:null
onwheel:null
outerHTML:"<h1>Some text</h1>"
outerText:"Some text"
ownerDocument:document
parentElement:body
parentNode:body
prefix:null
previousElementSibling:null
previousSibling:null
scrollHeight:0
scrollLeft:0
scrollTop:0
scrollWidth:0
shadowRoot:null
slot:""
spellcheck:true
style:CSSStyleDeclaration
tabIndex:-1
tagName:"H1"
textContent:"Some text"
title:""
translate:true
webkitdropzone:""
__proto__:HTMLHeadingElement
@Slapbox this is probably a bug in your code I think. I'm not sure what passing in an HTMLHeadingElement into Text.create would have ever done, but it's probably not something that core wants to support. Hard to tell without a reproduction though.
Pretty certain you're right.
I have no idea what that piece of code does. Didn't even realize I was calling it myself. I must have not looked at the call stack properly.
It was in my HTML deserializer rules, but was copied from some example/pastebin/gist serializer, and seems useless. It just happened to not break anything in the previous versions.
Thanks @ianstormtaylor
Most helpful comment
Pretty certain you're right.
I have no idea what that piece of code does. Didn't even realize I was calling it myself. I must have not looked at the call stack properly.
It was in my HTML deserializer rules, but was copied from some example/pastebin/gist serializer, and seems useless. It just happened to not break anything in the previous versions.
Thanks @ianstormtaylor