Slack: PR notifications stopped working after upgrading to new Slack integration.

[eelco]

We have a Slack channel set up with notifications of all pull requests with a certain label.

To achieve that, we did this:

Previously, this worked fine, but after upgrading from the “legacy” app to the new one, it broke. I already tried unsubscribing on subscribing again.

How do we debug / resolve this?

[eelco]

Also, I think it’s a bug that it subscribes to everything even though I specified pulls. I only unsubscribed from the commits because the label filters the rest and is only applicable to PRs anyway.

[emresandikci]

Use * keyword instead of all keyword it starts to send push notifications for all commits, I got help via GitHub support it's helped me. Several people had similar problems because there isn't mention of the keyword change on the slack's upgrade notification. But it's mentioned on docs.

[eelco]

I’m not interested in commit notifications though, I’m looking for PR notifications (specifically, when they merge). It looked like this before:

[sushmita-m]

@eelco please note that by default, subscribe command subscribes to issues, pulls, commits, releases. Note that this is true even when you specify [features] along with subscribe command. More info here.

If you are subscribed to pulls, you will receive notifications for pr closed, pr merged, pr reopened by default. There is no way to subscribe to just one of these events as of now. We will note this suggestion as a feedback.

If you are not interested in any features, can you do a unsubscribe [features] command.
Something like /github unsubscribe issues commits in your case. Thank you.

[sushmita-m]

@ashokirla marked it with feature label.

User wants to be subscribe to just pr merged events.

[eelco]

Hi @sushmita-m! I appreciate the explanation and the noting of the feature request.

Unfortunately, that’s not what this issue is about.

The notification of PRs merging are not getting sent to our Slack channel. They worked before (with the legacy app). How do we resolve this?

[sushmita-m]

@eelco Oops!! that was a long explanation.

I just verified PR merge behaviour with +label and I am able to get the notifications.

Sorry to bother you, can you do a \github subscribe list features and verify the the +label: matches with the one in your PR?

[eelco]

No bother at all! Thanks for your help 🙏

Note that it does work for other repositories. Just the notifications from FramerStudio have stopped since the upgrade.

[sushmita-m]

Weird that it is with only one repo under the same org! I don't see anything fishy in our logs yet!

Has the same GitHub user subscribed to all four subscriptions in the channel? Asking because while sending a notification, we do verify the access of the repo against the person whose GitHub account is used to subscribe.

Is it just the pr merge notification not working with FramerStudio. Can you subscribe without the label and check if the pr/any other notifications are working for this repo?

[eelco]

@sushmita-m Super weird indeed! Also that only that one broke 🤔

Has the same GitHub user subscribed to all four subscriptions in the channel

Yes, I did.

Is it just the pr merge notification not working with FramerStudio

Hmm, good one. I enabled issues on the repo, created and closed an issue, and created and closed another issue adding the automerge label on creation. Nothing shows up.

I then unsubscribed in Slack from the repo and resubscribed to everything without label filter. Created and closed an issue again. Nothing shows up.

I even re-installed the GitHub app to our Slack, unsubscribed and resubscribed and tested with an issue again. But, nada.

I then used /github signin to make sure my account was properly connected and tested with an issue again. Still… nothing.

I obviously can’t see the “internal” events, but we do have a webhook set up for all events too, and there everything triggers as expected. My hunch would be that it’s not the events not being sent, but something going wrong on the processing side. I don’t have access to those logs, obviously.

I would love to avoid having to install the Slack integration as our own app to get to the logs and debug this further, and I hope it can be resolved on your side.

[yskkin]

Reproduced in our private repo.
We receive notifications for opening a PR, but not for merging.
Our setting is not conditioned by label.

[topaztee]

+1 same issue

[chessbr]

Same issue, in our case we subscribed to the whole company just for releases:

/github subscribe [company] releases

We receive just notifications from a few repos

[Nivl]

Similar issue for us, we get notifications for branches but not for anything else (we only care for commits and pulls).

[sushmita-m]

@eelco apologies for the late reply.. we don't have any good news yet. I will be updating the support ticket you logged with us.

For others commenting on the issue, they look like different kind of issues. Please log a separate issues on the repo to get your issues resolved.

[kymikoloco]

What fixed it for us was reinstalling the New App, and signing in and resubscribing.

In some cursory tests with my IT dept, the Legacy App used the @github user, then installing the New App added @github2, but if you delete/remove the Legacy App, the only user available to invite was @github, but the New App listed @github2 as the authorized user:

[sushmita-m]

@eelco that took a long time. We fixed the issue and hope you are receiving the notifications now.

[sushmita-m]

I see that you confirmed in the internal ticket. Thanks for your patience. I am closing this issue.

[eelco]

Awesome, thank you so much!

[sjmueller]

Hi @sushmita-m PRs merged are still not showing up for us. You mentioned:

If you are subscribed to pulls, you will receive notifications for pr closed, pr merged, pr reopened by default.

But this is not the case for us -- our subscription looks like this:

In the legacy GitHub integration we used to receive these PR merge updates:

But even as of 5 minutes ago, nothing happens in slack when we merge a PR. We've tried unsubscribing and resubscribing, nothing works. Can you give specific instructions on what to do in order to get PR merges showing up again?

[sushmita-m]

@sjmueller I checked the logs and you are running into a permission related issue when we are processing the pr merge and closed notifications. Can you run a signin command once and check if that resolves the issue?

[sjmueller]

I ran /github signin and followed the instructions to enter the code:

After entering the code, it said success:

I then opened a new PR and it showed up in Slack:

Then after merging, no message appeared in Slack, so it is still broken. Using the /github signin does not fix the problem.

[sjmueller]

@sushmita-m do you have any update as to why permissions are broken, and why they cannot be fixed by using the signin command? What is your suggestion to fix the problem? Also, shouldn't this issue still be open considering the trouble everyone is still having with the integration?

[sushmita-m]

@sjmueller sorry, this was not being actively tracked because of this issue being closed. I logged a internal issue in engineering for this. Can you also open a new issue on the integrations repo/ or log a ticket at https://support.github.com/contact to get updates.

[sjmueller]

@sushmita-m why open another issue, why not re-open this one? @eelco stated:

The notification of PRs merging are not getting sent to our Slack channel. They worked before (with the legacy app). How do we resolve this?"

This is exactly what we (and other teams) are experiencing. If there is a resolution beyond your suggestion of using signin (didn't work), please share.

[pish11010]

Hi,
We also received only notifications for opening PRs (without merging, close, ready for review) after upgrading to the new Slack integration. (list features is issues, pulls, releases, reviews)
Now It works after adding permissions in Github. (Read and write access to deployments, issues, and pull requests)

Check your Github Repo > Settings > Integrations (Installed GitHub Apps) > Slakc Configure > Permissions

Maybe display like this.

Then, add permission using 'review request' button.

Hope this helps.

[sushmita-m]

@sjmueller As far as I am aware, we haven't updated the permissions to the Slack app on .com side in quite some time. Anyway, the org/account admin would be notified if an update is required.

As I have mentioned before, you are running into a permission related issue. Can you go to your org settings > installations > Slack configure and check as @pish11010 suggested.

[sjmueller]

Thanks @pish11010 your suggestion was very clear and fixed the problem for us!

[sushmita-m]

Thank you for adding the solution @pish11010. @sjmueller , glad that your issue got resolved.

[sjmueller]

@sushmita-m but this issue shouldn't be closed! To be clear:

1. Everything was working perfectly with the old GitHub integration with Slack
2. We were forced to upgrade to the new GitHub integration
3. Following the upgrade path caused our integration to break, as countless others are experiencing
4. The original suggestion did not work to fix the problem
5. @pish11010 was able to discover steps to fix the problem that was introduced by upgrading

The issue here is that upgrading the GitHub Slack integration causes a permissions discrepancy that isn't automatically resolved. This ticket should remain open until someone says "We figured out the problem in the upgrade process, and other teams that upgrade will no longer experience the bug"

[sushmita-m]

@sjmueller For the original issue logged by @eelco none of the notifications worked for one repo. It was a bug on our side and we fixed it.

Agree that this needs to be investigated. I kept the internal issue open, sorry for the lack of communication. If we discover something that needs to be notified to the users, we will update our documentation.

Your issue is not something common. It is specific to not receiving certain notifications. It could be your org related settings.

Can you check if an org admin received a notification via email asking to update permissions on the Slack app post upgrade?

As I have said you can log new issue saying users prompted to accept permissions on upgrade.

[sushmita-m]

@sjmueller I finally figured out the problem.
We had added a new permissions to the Slack app on July, 2019.

Starting with the new Slack app release, for a better user experience we are enriching the data. For example, Users will be able to see the updated label, reviewer info in the PR open notification message. When a PR is closed/ merged, users will be able to see the status of the PR in the first notification we posted as part of the PR open.

To provide this enrichment, we need the users to be on the latest version of the Slack app on the .com side. Though we haven’t updated the Slack app on the .com side, it is required for users to be on the latest version to see all of the notifications.

Having said this, we accept that it is a bad user experience to mandate the users to update and to not inform beforehand.

1. We are working to fix this on priority. So users who are on older versions of the app are not mandated to update/ and will not have a broken experience.
2. I am working with our PM to get the documentation updated.

[sjmueller]

Great job investigating @sushmita-m 👏 glad there is a better understanding of the problem. We went weeks having no idea how to fix or what went wrong, and documentation will help. You should also consider detecting older integrations, and showing a heads up message during the upgrade process: "Please make sure you've accepted any request for updated permissions on GitHub, otherwise some notifications may not work as intended."

[sushmita-m]

Thanks a ton @pish11010 and @sjmueller. We have fixed this. Users will continue receiving PR merged and closed notifications irrespective of the Slack app version they are using on the GitHub.

We are working on an experience to notify the users about updating the Slack app on GitHub.