Slack: Comment display regressed compared with legacy integration

[brasic]

We tried switching to the new slack integration for our private repo but noticed that PR comments are not displayed. Instead the entire content of the notification is "[USER] commented on pull request" with a link to the comment. Any reason the comment body itself isn't present in the notification like it was in the previous integration?

[bkeepers]

Hi @brasic, full comments should be working. For example, here is the notification we got when this comment was posted:

Check out the docs on configuration, and if you continue having issues, feel free to get in touch with details on which repo/account you're having issues with.

[bary822]

Comments on PR itself are cast to Slack perfectly though, those on discussion are not.
Any tips to turn it on? @bkeepers

[brasic]

@bkeepers Thanks for the confirmation that this is supposed to work, but this isn't a configuration issue, I'm confident that it's a bug in the integration. Upwards of 90% of our comments work as expected but some do not, and there doesn't seem to be an obvious pattern. Here's an example image I just pulled from slack of two comments in a single discussion that didn't get any text:

here are the comments in github that triggered those two notifications:

One interesting thing about the difference between notifications that include the comment body and those that do not is that the "working" notifications' primary link includes the #issuecomment-1234567 anchor in the link, whereas the ones that include no content are a bare link to the PR with no anchor.

If I had to guess, this looks related to some asynchronicity on your side. Perhaps the integration is reading from a lagging database slave before the data it needs is present?

[bary822]

Seems like this has been resolved by a PR recently merged.

[bkeepers]

@brasic thanks for the report. AS @bary822 pointed out, everything should be all fixed up with review comments in #409.

[brasic]

@bkeepers I'm not sure if #409 changed this but we are no longer receiving comments not associated with a review, despite being subscribed to comments:

To reproduce this:

• pick a random commit and open it via the repo/commit/SHA endpoint (as opposed to repo/pulls/NUM/commits/SHA)
• make an inline comment
• email notifications go out, no event at all shows up in slack.

This definitely works in the old webhook-based slack integration.

[bkeepers]

@brasic Commit comments aren't currently supported. I opened #432 to track it.

[brasic]

Thanks!