Skywalking: Consider to use testcontainer for collector test cases

Created on 11 Jun 2018  路  5Comments  路  Source: apache/skywalking

We don't improve our collector test cases for a long time, most reasons are about env dependencies. And I found testcontainers-java by following @bsideup .

It looks like interesting to me, several simple lines of code, you could start up a container in Java test cases.

I think we could try to use this, at least in our ElasticSearch or H2 storage implementor. At least, write some POC codes first.

FYI @hanahmily @ascrutae @peng-yongsheng Let's find out would this be helpful?

backend wontfix

Most helpful comment

Here is a list of similar uses:

All 5 comments

Thanks @bsideup to write this interesting project.

@wu-sheng thanks for your warm words, but I must point out that the project was created and being leaded by @rnorth, he wrote it! 馃挭

But I'm indeed happy to help you folks to integrate it, especially given the fact that I joined the Testcontainers project when I was doing the APM development at ZeroTurnaround :D

Let me know how I can help!

Here is a list of similar uses:

@wu-sheng thanks for your warm words, but I must point out that the project was created and being leaded by @rnorth, he wrote it! 馃挭

Sorry. Thank both @rnorth and @bsideup

e2e and CI with IT tests have been set up by @kezhenxu94. No need to keep this open.

We keep working on e2e and IT tests.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

wuxingye picture wuxingye  路  4Comments

hanahmily picture hanahmily  路  5Comments

cyejing picture cyejing  路  5Comments

alishangtian picture alishangtian  路  3Comments

Icefoxes picture Icefoxes  路  3Comments