Skript: NullPointerException in UnresolvedOfflinePlayer

[elgbar]

For some reason I get an error with UnresolvedOfflinePlayer. I looked in the file that you can just add a catch for a NullPointerException to suppress the error. 😈

[bensku]

No, I'm not going to ignore this error. It needs to "crash" if it doesn't work, otherwise much worse things might happen. Including providing wrong data to scripts and possible variable corruption.

This is strange bug, because it almost seema that static final field which IS initialized would be null. Weird.

[Weefle]

Please try again to resolve it! :/

[bensku]

Attempting a fix, can't say if will be successful.

[bensku]

Wait what Github. I definitely did not _close_ this.

[28andrew]

Maybe it was smart and closed this because you wrote fix #237

[Namnodorel]

Yes, Github automatically closes issues if you reference it with certain keywords in a commit

[bensku]

Hm. I would rather wait for user to confirm that it was fixed, or at least for the release to be uploaded. But anyway...

[Weefle]

The bug is still there!
2.2-dev21c

[bensku]

Yes, but what error message do you get? I "improved error reporting" for this, since last error message was basically saying "Java standard thread API returns null", which is not likely.

[Weefle]

When I reload the latest spigot-1.11 and skript 2.2-dev21c, I get this error after a while: http://hastebin.com/upucacutex.md

[bensku]

Yes, thanks! Now I can try to fix this...

[Weefle]

And ... not fixed in 2.2-dev22b: http://hastebin.com/becupivawo.md

[melinstagibson]

Would this actually solve the treatment of playernames compared to uuids or
would it still be like var.%oldname% =\= var.%newname%?

Am 27.11.2016 7:32 nachm. schrieb "Weefle" [e-mail]:

And... not fixed in 2.2-dev22b: http://hastebin.com/becupivawo.md

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bensku/Skript/issues/237#issuecomment-263138376, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ASd7ogJ9k9lBohRScbe4sx9ZStWV9Rvbks5rCczCgaJpZM4Kw0uT
.

[Weefle]

I don't know :/

[bensku]

No, this wouldn't solve that. Probably.

[keva5]

As of v2.2-dev22f error is persisting.

https://hastebin.com/nucaxetuke.md

(Not triggered by a specific script, usually only seen on start/enable of plugin around ten seconds after)

[bensku]

Attempting some kind of fix for next release. I still have no idea why this happens for some people but not others.

[Weefle]

I can confirm this error again in the latest release: 2.2-dev22g
Same error :/

[elgbar]

Just a side note that might help, I am running my server in offline mode.

[RoyCurtis]

FWIW, I accidentally found a reliable reproduction for this, whilst testing another issue:

Tested with only Skript v2.2-dev22g on Spigot 7d78b81-f9e0440 and Paper b993

1. Start the server
2. Wait for up to 15 seconds after loading is done. Observe there are no Skript exceptions
3. Execute reload confirm to reload the server
4. Wait for up to 15 seconds after loading is done. Observe that a Skript NPE eventually happens

I realize that server reloading is unsupported, but I have not seen this being asked here: those who are getting this issue, was this after a /reload or from cold server startup?

[Syst3ms]

/reload has always caused a shit ton of isuues to me. I've not encountered those, but i know two others that are still very annoying and severe :

• Doing a /reload makes Skript unable to load a script properly. Skript will not detect changes on a script in that case.
• You can't reload anything. And I mean anything. Throws an error in console each time.

In both cases, here is the fix :

1. Remove Skript and all addons. Of course, save the scripts beforehand.
2. Restart the server
3. Put Skript and all addons back. Also import the scripts.
4. Restart the server

[TheBentoBox]

You probably don't even need to do an additional restart where you remove Skript and all of the addons, just giving the server a full and proper restart should allow everything to register properly and do the job fine.

[Syst3ms]

@TheBentoBox I've restarted many times and the error persisted. A full reinstall was the only way.

[Tuke-Nuke]

Hi, I want to report this problem to see if it maight be helpful:

Stack trace: https://hastebin.com/sonemovare.md

Infomartion:

• The error occurred when I tried to stop the server (it's a test server in my own PC). I was starting and stopping many times as I was making some request for your fork (I didn't make any changes, only few expressions added). It only did happen once.
• Plugins: TuSKe v1.7-beta.3, SkRambled v2.1, skUtilities v0.7.9. (It is a test development server)
• Running Spigot git-Spigot-90f61bc-29e1d72.
• 0 Variables stored.
• 0 Scripts loaded.

[ghost]

Hi! I come here to report this same error when I stop my server. I can't close it and restart it...
I'm on 1.11.2 spigot server with Skript 2.2 dev24b.

Addons : MundoSk, SharpSk, Skellett, SkQuery, SkRayFall, SkStuff, SkUtilities, TuSKe and Umbaska.

Important : I noticed that error happens only with the plugin Dynmap installed and when it does a render!

Thank you for your work and keep going! :D

[23:54:21 ERROR]: #!#!

[Syst3ms]

I think @bensku is going to cry

[bensku]

I reworked that again, let's see if it helps with next version. I also fixed other problems with offline players.

[supertassu]

Can confirm at latest version (dev25) & Spigot 1.11.2.

[Remixful]

I am still getting this error as of Skript version 2.2-dev25 and was told to report here.

[bensku]

I'm confident that this has something to do with /reload, or similar effects. However, "similar effects" might include server shutting down, so it is a bit more complicated...

[FilipeNock]

Same error.....

[Shane1199]

This bug is still happening in the newest version of Skript, I was on 1.7.10 with the protocol hack.

EDIT:
I do have WildSkript and an apparently broke skQuery.
Error:

[19:36:48 ERROR]: #!#! 
Exception: java.lang.IllegalStateException thrown from the UncaughtExceptionHandler in thread "Skript offline player resolver thread (fetches UUIDs from the minecraft servers)"
[19:36:48 ERROR]: #!#! [Skript] Severe Error:
[19:36:48 ERROR]: #!#! An error happened when trying to enably resolving offline players, so the feature has been turned off. Please report this at https://github.com/bensku/Skript/issues/237
[19:36:48 ERROR]: #!#! 
[19:36:48 ERROR]: #!#! If you're developing an add-on for Skript this likely means that you have done something wrong.
[19:36:48 ERROR]: #!#! If you're a server admin however please go to https://github.com/bensku/Skript/issues/
[19:36:48 ERROR]: #!#! and check whether this error has already been reported.
[19:36:48 ERROR]: #!#! If not please create a new ticket with a meaningful title, copy & paste this whole error into it (or use paste service),
[19:36:48 ERROR]: #!#! and describe what you did before it happened and/or what you think caused the error.
[19:36:48 ERROR]: #!#! If you think that it's a trigger that's causing the error please post the trigger as well.
[19:36:48 ERROR]: #!#! By following this guide fixing the error should be easy and done fast.
[19:36:48 ERROR]: #!#! 
[19:36:48 ERROR]: #!#! Stack trace:
[19:36:48 ERROR]: #!#! java.lang.NullPointerException: null offline player resolve queue
[19:36:48 ERROR]: #!#!     at ch.njol.skript.bukkitutil.UnresolvedOfflinePlayer$1.run(UnresolvedOfflinePlayer.java:59)
[19:36:48 ERROR]: #!#!     at java.lang.Thread.run(Thread.java:745)
[19:36:48 ERROR]: #!#! 
[19:36:48 ERROR]: #!#! Version Information:
[19:36:48 ERROR]: #!#! 
[19:36:48 ERROR]: #!#! [Skript] Severe Error:
[19:36:48 ERROR]: #!#! Exception in thread Skript offline player resolver thread (fetches UUIDs from the minecraft servers)
[19:36:48 ERROR]: #!#! 
[19:36:48 ERROR]: #!#! If you're developing an add-on for Skript this likely means that you have done something wrong.
[19:36:48 ERROR]: #!#! If you're a server admin however please go to https://github.com/bensku/Skript/issues/
[19:36:48 ERROR]: #!#! and check whether this error has already been reported.
[19:36:48 ERROR]: #!#! If not please create a new ticket with a meaningful title, copy & paste this whole error into it (or use paste service),
[19:36:48 ERROR]: #!#! and describe what you did before it happened and/or what you think caused the error.
[19:36:48 ERROR]: #!#! If you think that it's a trigger that's causing the error please post the trigger as well.
[19:36:48 ERROR]: #!#! By following this guide fixing the error should be easy and done fast.
[19:36:48 ERROR]: #!#! 
[19:36:48 ERROR]: #!#! Stack trace:
[19:36:48 ERROR]: #!#! java.lang.IllegalStateException
[19:36:48 ERROR]: #!#!     at ch.njol.skript.Skript.getVersion(Skript.java:187)
[19:36:48 ERROR]: #!#!     at ch.njol.skript.Skript.exception(Skript.java:1228)
[19:36:48 ERROR]: #!#!     at ch.njol.skript.Skript.exception(Skript.java:1179)
[19:36:48 ERROR]: #!#!     at ch.njol.skript.bukkitutil.UnresolvedOfflinePlayer$1.run(UnresolvedOfflinePlayer.java:59)
[19:36:48 ERROR]: #!#!     at java.lang.Thread.run(Thread.java:745)
[19:36:48 ERROR]: #!#! 
[19:36:48 ERROR]: #!#! Version Information:
[19:36:49 INFO]: /skript help
[19:36:54 INFO]: /skript help
[19:36:58 INFO]: /skript help

[Guarmanda]

still happening, but not on server start, only after two reloads for me. skript 2.2 dev 27 and 1.11 without protocol hack.
https://pastebin.com/uqGTNHrF

[TheBentoBox]

You shouldn't be using reload, nor reporting errors you get after using /reload. It's not really supported by Skript and it's an unstable thing to do in general.

[v3Monsta]

Started a fresh install of a server running PaperMC (git-paper-1147) and installed the latest Skript (2.2-dev29) and had this error occur during the server shutdown process, mainly the saving world process which hung for about 5 seconds before Skript displayed this error.

Log: https://hastebin.com/kixomasuwa.md

Restarting the server ended with the same error at the same time.

[Nariko13]

I am just doing what the console tell me to do, reporting the error to the link given, don't pay attention to me ^^"

[Weefle]

The error is still there in dev30d with the latest spigot 1.12.1 from Yve's mirror
The error happen at the /reload command: https://hastebin.com/ixitebiqiq.md
(the version is 1.9 on the link but its the same in 1.12.1, the server is in online-mode)

[bensku]

/reload is unsafe to use with Skript. Don't do that.

[BreathTakeng]

I had Skript installed on my server. Not using a host. I installed Skript itself. It worked perfectly but when I installed the addons, it started giving that message.

[Xeukxz]

[Xeukxz]

help

[Legoman99573]

I get the same issue and prevents the server from shutting down, thus forcing me to kill the server proccess.

Using paperspigot 1.12.2 and latest skript bensku release.

[Xeukxz]

welp its so annoying!

[Xeukxz]

java.lang.NoSuchMethodError: org.bukkit.DyeColor.getData()B
at ch.njol.skript.util.Color.(Color.java:82) ~[?:?]
at ch.njol.skript.SkriptCommand.(SkriptCommand.java:60) ~[?:?]
at ch.njol.skript.Skript.onEnable(Skript.java:254) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264) ~[spigot-1.12.2.jar:git-Spigot-d21162c-61e0c69]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:337) [spigot-1.12.2.jar:git-Spigot-d21162c-61e0c69]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:403) [spigot-1.12.2.jar:git-Spigot-d21162c-61e0c69]
at org.bukkit.craftbukkit.v1_12_R1.CraftServer.enablePlugin(CraftServer.java:384) [spigot-1.12.2.jar:git-Spigot-d21162c-61e0c69]
at org.bukkit.craftbukkit.v1_12_R1.CraftServer.enablePlugins(CraftServer.java:333) [spigot-1.12.2.jar:git-Spigot-d21162c-61e0c69]
at net.minecraft.server.v1_12_R1.MinecraftServer.t(MinecraftServer.java:422) [spigot-1.12.2.jar:git-Spigot-d21162c-61e0c69]
at net.minecraft.server.v1_12_R1.MinecraftServer.l(MinecraftServer.java:383) [spigot-1.12.2.jar:git-Spigot-d21162c-61e0c69]
at net.minecraft.server.v1_12_R1.MinecraftServer.a(MinecraftServer.java:338) [spigot-1.12.2.jar:git-Spigot-d21162c-61e0c69]
at net.minecraft.server.v1_12_R1.DedicatedServer.init(DedicatedServer.java:272) [spigot-1.12.2.jar:git-Spigot-d21162c-61e0c69]
at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:545) [spigot-1.12.2.jar:git-Spigot-d21162c-61e0c69]
at java.lang.Thread.run(Unknown Source) [?:?]

[28andrew]

This doesn't belong here, create a new issue.

[Xeukxz]

What do you mean it doesnt belong here??

[28andrew]

This is a closed issue involving a NullPointerException while resolving offline players.

[Xeukxz]

Ahh i see

[TheBentoBox]

You're also not even using this version of Skript @BallisticDev

[Xeukxz]

??

[Legoman99573]

you are using the original skript plugin. use this fork instead.

[Xeukxz]

This makes no sense

[Xeukxz]

Im just trying to get this fixed

[28andrew]

You're using the version of Skript, 2.1.2, that was made by njol. This github repository is for the Skript version made by bensku. Try switching to this, by going to releases. Also if you're still having issues, please make a new issue instead of bloating this one up.

[Xeukxz]

Ahhh

[Xeukxz]

[bensku]

It does not seem that there is anything relevant concerning this issue anymore. It has been fixed for good.

Edit: whoops