Skaffold: Some FAILED skaffold events do not return error code

[go-nelango]

Skaffold devloop events with status == 'Failed' are expected to have a non-null error code. If failed events are missing the error code, failure_reason defaults to UKNOWN_ERROR in IDE metrics (and this is parsed as failure_phase = UKNOWN and failure_reason = ERROR in cloudcode.skaffold.session.end). Could you please investigate why failed events might be missing error code?

The above case makes up >9% of total errors in cloudcode.skaffold.session.end based on data from 8/01/2020 to 9/30/2020 and skaffold version >= v1.13.2

This case makes up 15% of unknown errors in cloudcode.skaffold.session.end based on data from 8/01/2020 to 9/30/2020 and skaffold version >= v1.13.2

[go-nelango]

@tejal29 FYI

[MarlonGamez]

Commenting just to let whoever sees this know that we're hoping to prioritize this this quarter! :)

[tejal29]

We have few PRs already implemented. This is still a P1 for us.

[tejal29]

This should be addressed by #4926

[tejal29]

Closing for now but lets re-open if we see more such cases in v1.16.0

[briandealwis]

Closing, but @tejal29 will reopen if required.