skaffold fix should leave comments as-they-are

Created on 15 Apr 2020  路  6Comments  路  Source: GoogleContainerTools/skaffold

Currently skaffold fix gobbles up all comments. This is a feature request to leave the comments in place

Expected behavior

comment line beginning with # should be let alone

Actual behavior

comments are removed

Information

  • Skaffold version: v1.7.0
  • Operating system: Ubuntu 16/18
  • Contents of skaffold.yaml: N/A
arefix fixit help wanted kinfriction prioritp3

Most helpful comment

This seems like an entirely reasonable request. Thank you for the suggestion!

All 6 comments

This seems like an entirely reasonable request. Thank you for the suggestion!

@tstromberg any idea on how we should do it?

I keep re-applying the comments after every skaffold fix :sweat_smile:

Maybe, have some comment-next line mapping whenever skaffold fix is done so that it can be restored after fix. But, this would be a custom approach. Not sure if a standard way is available.

@tvvignesh, i have a PR in works.
due to time constraint, i could not finish. Is this something you would be interested in completing? I can help ?

@tejal29 Hi. Currently working on my startup (that will take 2 more months to complete) since I am working alone. While I can take this up in the future, now might be difficult. Not sure what timeline you have for this.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rahulwa picture rahulwa  路  4Comments

GeertJohan picture GeertJohan  路  3Comments

r2d4 picture r2d4  路  3Comments

strikeout picture strikeout  路  4Comments

woodcockjosh picture woodcockjosh  路  4Comments