Skaffold: Feature Request: Allow docker build arg to pick values up from the environment values also

[rahulwa]

[jomarinb]

I'm currently using envsubst as a workaround.

envsubst '\$ENV1 \$ENV2' < skaffold.yaml | skaffold run -f -

[balopat]

Hi @rahulwa can you provide more information about your use case?

[rahulwa]

I want to use the same Dockerfile for different environments (staging, production) [this case is easily handled through skaffold profiles] and some variables are even different in same environment(like some base links in reacts assets, even though react supports these variables through environment, I cannot pass it through Dockerfile because skaffold doesn’t handle it). Hope it makes sense.
Something like this

Anyway, if we are allowing environment variables for others configs, why not for this also?
It will provide consistency and intuitiveness.

[nkubala]

@rahulwa that sounds reasonable, it shouldn't be too difficult to plumb env vars through to the docker build args. would you be interested in sending a PR?