Site-kit-wp: Analytics setup, incorrect message when there are no existing accounts but has existing tag

[lucymtc]

Bug Description

While setting up Analytics module, if there is an existing tag found and the user has no analytics accounts the message shown is incorrect, indicating the user needs to create an account.
The message shown should inform of the existing tag coming from an external source, and that the user does not have access to it.

Steps to reproduce

1. Insert Analytics tracking code through wp_head hook or directly into header.php in the theme.
2. Go to Settings, activate Analytics.
3. Authorise with Google account that has no Analytics accounts.
4. See message "Looks like you don't have an Analytics account yet..."

Screenshots

Currently:

Expecting:

Additional Context

---

_Do not alter or remove anything below. The following sections will be managed by moderators only._

Acceptance criteria

• User clicks Activate Analytics button in Settings
• a message is shown informing about the existing tracking code and that it comes from an external (non Site Kit) source, and that the user does not have access (they need to either request access or remove the existing code)
• in this scenario, the user is blocked from proceeding

Implementation Brief

When requesting tag-permission
https://github.com/google/site-kit-wp/blob/b42304c5e577eb13fa5934bd9c02f2a0cba1e44b/assets/js/modules/analytics/setup.js#L95
if the user has no access to the existing tag found the response will throw an error, therefor getAccounts() doesn't get called and existingTag state is never set.

We can rely on errorCode state to prevent from rendering dropdowns or create account/re-fetch buttons.

Add the following statement after isLoading check

https://github.com/google/site-kit-wp/blob/b42304c5e577eb13fa5934bd9c02f2a0cba1e44b/assets/js/modules/analytics/setup.js#L720-L723

if ( 'google_analytics_existing_tag_permission' === errorCode ) {
    return null;
}

This way we will only be rendering the error message from tag-permission response.

Changelog entry

• Clarify Analytics status if there is an existing tag and the user does not have any accounts.

[felixarntz]

@lucymtc Acceptance criteria look good (taken from #358, for reference), feel free to start with the implementation brief.

[lucymtc]

@felixarntz we need to change the order of steps, currently getAccounts() is first called and then getExistingTag()

https://github.com/google/site-kit-wp/blob/c70ca3a495ed979bcc69e8c2b2c9a3578b2be9a7/assets/js/modules/analytics/setup.js#L87-L93

It will likely be fixed with https://github.com/google/site-kit-wp/issues/83

[felixarntz]

@lucymtc You can reference #83 in the IB as a blocker and write the rest of it based on that already being implemented.

[lucymtc]

@felixarntz confirming this issue is fixed with latest changes merged from https://github.com/google/site-kit-wp/issues/83
Following the steps to reproduce and seeing the expected message:

[felixarntz]

@lucymtc Note that the ACs state the buttons should not appear in this scenario because the user is blocked. This is a small change we'd still need to make I believe.

Double-checking with @marrrmarrr - if there is an existing tag and the user does not have an account, they should not be able to create one right? The buttons should not be visible?

[felixarntz]

@lucymtc I confirmed with @marrrmarrr, there shouldn't be any buttons to create a new account or re-fetch if there's an existing tag. Let's address that as part of this issue. If there's an existing account, the user should not be able to proceed (only see the "Cancel" link).

[felixarntz]

IB ✅

[aaemnnosttv]

@felixarntz this one is blocking #358 so please move that one out of blocked as soon as this one is no longer blocking.

[adamsilverstein]

Works well in my testing; moving to "Acceptance".

Testing Approach

• Manually add Analytics tag to local site header (edit theme->header).

I tested analytics setup with a user that didn't have access to the property of the tag present in the site theme, seeing this message:

At this point I am blocked from proceeding as expected.

Additional Testing

I logged in again as the correct user who does have access to the tag that is already on the site, the UI correctly showed the property preselected, and the UI was "disabled" or locked to the property ID that I had inserted into the theme header: