Sinon: Regression introduced in #1807

Created on 29 May 2018  路  7Comments  路  Source: sinonjs/sinon

The simple PR #1807 to update the dependencies broke the build for master.

Both IE11 and Safari has problems as of (IE11 Promise related, Safari faking time). Not sure why or what caused it, but lolex is a reasonable guess when it comes to Safari.

We could simply revert the PR, but it should be possible to find the regression in the list of dependencies.

picture fatso83

Most helpful comment

sinonjs/lolex#176 doesn't make sense... Which one did you mean?

EDIT: Did you mean https://github.com/sinonjs/lolex/pull/169?

picture SimenB on 30 May 2018
👍2

All 7 comments

Installing lolex 2.4.2 fixes the Safari issue.

fatso83 picture fatso83 on 30 May 2018

I added Safari 9 to the list of browsers now. The regression was introduced in sinonjs/lolex#169. Seems like Safari doesn't handle that quite right. Ping @SimenB

fatso83 picture fatso83 on 30 May 2018

@sinonjs/core this is what is breaking the build. We could install lolex 2.4 or fix 2.7 (or both)

fatso83 picture fatso83 on 30 May 2018

sinonjs/lolex#176 doesn't make sense... Which one did you mean?

EDIT: Did you mean https://github.com/sinonjs/lolex/pull/169?

SimenB picture SimenB on 30 May 2018
👍2

Yes, that's the one. it was late in the night ;)

fatso83 picture fatso83 on 30 May 2018

Mind explaining why the JSDOM integration test was causing this issue? I'm not sure I understand.

benjamingr picture benjamingr on 30 May 2018

It's not the test. It's the property assignment in the same PR:
https://github.com/sinonjs/lolex/commit/8ec6170cc47a0fe3a351f7d2292041d60d832c1a

fatso83 picture fatso83 on 30 May 2018
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

kevinburkeshyp picture kevinburkeshyp  路  4Comments
tinganho picture tinganho  路  3Comments
zimtsui picture zimtsui  路  3Comments
kbirger picture kbirger  路  3Comments
akdor1154 picture akdor1154  路  4Comments