Simplenote-electron: Accessibility: Revision selector needs a label

Created on 21 Jun 2019  路  8Comments  路  Source: Automattic/simplenote-electron

The revision selector input in this component does not have a label. It needs a label that is hidden

<input class="slider" type="range" min="0" max="5" value="5">

What

Add a hidden lablel to the revision selector input

Why

To make it accessible to screen readers

How

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/forms/Basic_form_hints

Screen Shot 2019-06-21 at 1 54 44 PM

accessibility feature request good first issue

All 8 comments

Hi, i would like to work on this issue.

PR's are welcome. Sorry I didn't respond sooner!

See also #980

I'm sorry i could not work on this but i had some trouble.
If anyone else want to it is ok for me

Hi, I would be happy to work on this if possible :)

@tbourrely go for it! what do you need from us to get started?

you are welcome to fork the repo and submit a PR 馃槃

Well, once I can get my environment working, I will be good to go 馃槃 !

Looks like things have been refactored since this was opened. This input is now in the Slider component.

May want to approach it similar to how we work with the Search input.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

damamasss picture damamasss  路  4Comments

guarani picture guarani  路  3Comments

moniuch picture moniuch  路  3Comments

gubrist picture gubrist  路  4Comments

tavilla61 picture tavilla61  路  4Comments