Simplebar: Create an Angular plugin

Created on 14 Apr 2019  路  7Comments  路  Source: Grsmto/simplebar

Hey guys,

We are looking for a contributor for an Angular plugin. It's a simple wrapper just like our Vue and React ones. That should be a good "first PR", shouldn't take too long to work out neither.
You can take example on our existing wrappers and just do the same thing for Angular.

Please comment here if you're interested in taking this task!

Help needed

Most helpful comment

Hi @Grsmto ,

Thanks for the plugin. Please assign this issue to me i'll create PR once i have done.

All 7 comments

Hi @Grsmto ,

Thanks for the plugin. Please assign this issue to me i'll create PR once i have done.

@dinesh-here hey, did you come up with something?

Hi @Grsmto

I am held up with some other work last month. i'll try to start this weekend.

Thanks!

Hi @Grsmto

I have created wrapper in angular with demo. It's available in https://github.com/dinesh-here/simplebar/tree/simplebar-angular-/packages/simplebar-angular

I am not familiar with rollup for packaging angular. Can we use ng-packager?

Please check the branch and let me know. i'll submit the pull request if it's fine

Looks great!
Yes I suppose you can totally use ng-packager.

A few feedbacks on the code:

  • The package needs clean up in general, there are a lot of unrelated things like lot of useless dependencies like angular-router that are not needed for simplebar-angular.
  • Could you re-organise the folder so the demo is separated? At the moment we have the demos in /simplebar/examples/. Just create an angular folder in there following the example of the other plugin. So your /simplebar-angular folder will have only the plugin code.
  • We use Yarn here and not Npm. So if you could remove the package-lock.json.

Thanks for your work!

Thanks @Grsmto , I'll update the changes and create pull request.

Done in #363

Was this page helpful?
0 / 5 - 0 ratings

Related issues

luky1984 picture luky1984  路  5Comments

artaommahe picture artaommahe  路  6Comments

TheeOhioState picture TheeOhioState  路  6Comments

barnu5 picture barnu5  路  5Comments

ghost picture ghost  路  4Comments