Simd: Shorten all saturating instructions to "sat"

Created on 28 Aug 2020  路  7Comments  路  Source: WebAssembly/simd

The saturating instructions spell out the word "saturate".
I propose we shorten it to "sat" to be consistent with the truncation with saturation instructions, see https://webassembly.github.io/spec/core/text/instructions.html, e.g. 饾梻饾煥饾煢.饾棈饾棆饾棊饾棁饾柤_饾棇饾柡饾棈_饾柨饾煡饾煠_饾棇.

tracking

Most helpful comment

@penzn @abrown Does this sound good to you? I think this is straightforward enough that it probably doesn't need to be voted on in a meeting.

All 7 comments

I always thought lop and sop would have been better names for truncate and saturate, especially in an assembly language, but that kind of thing isn't really appropriate in a serious standard.

+1 for sat.

@penzn @abrown Does this sound good to you? I think this is straightforward enough that it probably doesn't need to be voted on in a meeting.

Sounds fine to me, and I don't think we need to vote unless there are any concerns about this.

Let's keep this issue open while we fix other WAT consumers too (e.g. binaryen, wabt). I'm also curious what we should do with the clang intrinsics. From the meeting last week, it sounds like we should batch these changes and do them all at once, is that right?

Yes, batching changes is always nice for Binaryen and LLVM, and I think it's ok if they lag behind a bit on the renaming. I separately opened #342 to discuss further changes to the intrinsic names.

wabt is done https://github.com/WebAssembly/wabt/pull/1553, llvm and wasm_simd128.h is not up to date.

LLVM is updated, closing.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

tlively picture tlively  路  6Comments

tlively picture tlively  路  10Comments

Maratyszcza picture Maratyszcza  路  11Comments

penzn picture penzn  路  9Comments

tlively picture tlively  路  8Comments