Silverstripe-framework: Inconsistency on the re-login dialog

[maxime-rainville]

Description

When your session expires in the CMS you will be prompted to log back in in a modal. This Modal displays an iFrame with a login screen.

• The button styles for the modal don't match the admin ones.
• There's a blank space with subtly different background colour below the iframe

Steps to Reproduce

• Access the CMS
• Using your browser's dev tool delete your session cookie.
• Navigate to different page

[maxime-rainville]

@silverstripeux Don't know how much you care about this. I'm thinking, it could be worthwhile redoing this thing in react with form schemas instead of using an iframe.

[clarkepaul]

The visual layout of this is shocking. Form schemas should allow for more control and less fragile styles I hope :)

[Cheddam]

Guessing this just wasn't looked at during the migration to Bootstrap in CMS 4 😅

[ScopeyNZ]

I feel like that isn't how it looked about a year ago in the CMS.

[maxime-rainville]

It's not something we look at very often. Because it's an iframe, it's got a somewhat different context than the rest of the admin area, so global style changes could very well have unusual affect in here.

I'll add a test entry for it in our HipTest/CucumberStudio.

[maxime-rainville]

Just added an entry to Cucumber https://studio.cucumber.io/projects/103281/test-plan/folders/705103/scenarios/4186105

[sachajudd]

This is one of the only designs I can find for the timeout modal @clarkepaul Timeout design. Let me know if this is still the direction we are going for and I'll upload to DSM.