Silverstripe-framework: Suspect comparison in handleRequest

Created on 5 Mar 2019  路  4Comments  路  Source: silverstripe/silverstripe-framework

Sometime I dig into the code to see how it works and I meet some "interesting" stuff: please, tell me if reporting here this kind of issues is not appropriate or if there is a less invasive way.

Quoting this code:

in_array(strtolower($action), ['run', 'doInit']))

There is something wrong: or doInit must not exist or it should be doinit.

CC @dhensby as this seems to be introduced by PR #3926.

All 4 comments

What a good spot! looks like that needs patching

Sometime I dig into the code to see how it works and I meet some "interesting" stuff: please, tell me if reporting here this kind of issues is not appropriate or if there is a less invasive way.

Please do! Always happy to receive bug reports or discuss "interesting stuff"! 馃檹

I've merged up, too

Was this page helpful?
0 / 5 - 0 ratings