Silverstripe-framework: JS Confirm dialog when creating versioned DataObject

[leomeloxp]

As briefly discussed on Slack SS4 channel, I'm getting an issue when trying to create new versioned DataObjects, a browser confirmation prompt appears when clicking the create button asking if _I'm sure I want to navigate away from the page_ AFTER an AJAX call has already fired to create the object.

I've created a small repo where you can reproduce the issue, simple clone it, composer install and /dev/build then follow my steps below.

1. Navigate to Example model admin interface
   

1. Click Add New MyObj
   

1. Put some information in
   

1. Click Create (pop up appears
   

1. Click Cancel (notice that the URL updated to reflect new object ID)
   

1. Click Create again (pop up appears again, create button has Create text and loading animation overlapping)
   

1. Click okay in the pop up (notice URL updated again, now with newest object ID)
   

1. Navigate back to see 2 instances of the object in the GridField
   

[DorsetDigital]

I've seen the same behaviour on a non-versioned DataObject attached to a page (edited via Gridfield).

[christopherdarling]

Getting the same issue here too

[chillu]

Thank you for the awesome issue description! ⭐️ ⭐️ ⭐️
I've added this as an impact/high issue into the 4.0.1 milestone.

[phalkunz]

PR: https://github.com/silverstripe/silverstripe-admin/pull/354