Silverstripe-framework: Replace oEmbed implementation with 3rd party library

[sminnee]

Follow-on from #5461.

There's no need for us to maintain our own oEmbed implementation. Let's move to a 3rd party package for this. https://github.com/oscarotero/Embed looks like a decent implementation.

https://github.com/essence/essence is another reasonably popular one, although it has more external dependencies, isn't commit to as frequently, and isn't as popular on packagist, so the oscarotero one gets my vote.

[Firesphere]

Hmmm, to bad I can not assign myself to this. I've started stripping out oEmbed in favor of oscarotero now, will possibly create a separate branch for essence if wished.

p.s.
I vote yes. From the looks of it, Oembed is... ehm... ehm... I will not continue putting down thoughts here, for the sake of humanity, okay? :P

[Firesphere]

oscarotero embed requires Guzzle 5.
From the looks of it, essence is slightly less complex. Any preference?
@silverstripe/core-team pong

[kinglozzer]

oscarotero embed requires Guzzle 5

It’s optional - you can configure how the requests are resolved (it’s only in require-dev in composer.json, not require).

+1 for https://github.com/oscarotero/Embed

[kinglozzer]

Also, allow me to ping @silverstripe/core-team for you @Firesphere :D

[Firesphere]

Pong. Thanks @kinglozzer :D

[dhensby]

@kinglozzer is correct, Guzzle is just suggested, not required.

+1 for https://github.com/oscarotero/Embed

[sminnee]

+1 for oscarotero/Embed without Guzzle. essence only looks less complicated because it's spread across 3 packages, I expect ;-)

[Firesphere]

I admit I only had a quick look at it. Will go with oscarotero then. On functionality, I doubt it'll be very much different.

[Firesphere]

While we're at it...
What about the shortcode parser? I'd think using https://github.com/thunderer/Shortcode would be a nice way to get those kind of dragging-on things out of the way
_edit_
The package after the edit that is, not the docroot of a website.

[dhensby]

Yes please, lets pull all this stuff out :)

Lots of our implementations of these features are quite MVP and have bugs that just never get round to being fixed.

[sminnee]

I think that solving the shortcode parser as part of this PR isn't the best idea. Get oEmbed extracted, the PR raised (and merged), and then move on to shortcodes.

[dhensby]

Yes, different pr

[Firesphere]

Oh obviously different PR. Just added it here as the thought came up. Will open a new item for it when I get to it (or someone else does)

[dhensby]

This is done