Signal-android: Time/date not translated in image view

Created on 21 Jun 2015  路  6Comments  路  Source: signalapp/Signal-Android

2.19.0
_Edit: see third comment for a proper bug report._
phil thomas katt enterprise room

Most helpful comment

I found the root cause of this problem:
To get formatted timespan strings usually the class DateUtils inside the Signal project is used. This class' methods consider the language set within Signal. Such methods are used for the message bubble timestamps and the timestamps in the conversation list.
For the media preview's timestamp currently a method of Android's DateUtils is used, which considers the system language.

I am going to work on this.

All 6 comments

Disagree

screenshot_2015-06-21-21-47-56

@McLoo Do you have system language set to Deutsch?
I can only reproduce this if system language is different than TS language. E.g. system: English; TS: Deutsch.

Steps to reproduce:

  1. System language: _English (US)_; TS language: _Default_
  2. Confirm that the time in image view is in _English_
  3. Change TS language to _Deutsch_
  4. Time in image view is still in _English_ (should be in German)
    ptk

Tested on TextSecure 2.19.0 with

  • Nexus 4, stock Android 5.1.1
  • Huawei U8800, Android 4.0.4

confirmed.
seems to be #2815 related to another "the absolute system locale monarchy decides" issue, I currently can't find issue

Hmm... wasn't #2815 caused by rotation changes? This happens if system language and TS language are different.

yeah #2815 is a pain cause by screen rotation and can only be resolved by moving all our dynamic language stuff into the base activity classes from which all other activities extend.

I found the root cause of this problem:
To get formatted timespan strings usually the class DateUtils inside the Signal project is used. This class' methods consider the language set within Signal. Such methods are used for the message bubble timestamps and the timestamps in the conversation list.
For the media preview's timestamp currently a method of Android's DateUtils is used, which considers the system language.

I am going to work on this.

Was this page helpful?
0 / 5 - 0 ratings