Signal-android: Emoji, Attachment, and 'Android Back' buttons not working in conversation

Created on 20 Oct 2020 · 20Comments · Source: signalapp/Signal-Android

[x] I have searched open and closed issues for duplicates
[x] I am submitting a bug report for existing functionality that does not work as intended
[x] I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
[x] This isn't a feature request or a discussion topic

Bug description

When in a conversation (private, old group, new group), the emoji button (the one left to the message input box), the attachment button (blue plus) and the Android back button are not working.
The camera, microphone, text input and send buttons are all working. The three dots (settings) button and the 'back button' (<-) in the top-left corner also work.
When you are entering text (so the keyboard is extended) and press one of the faulty buttons, the keyboard closes.

Steps to reproduce

Open Signal
Open a conversation
Press back/emoji/attachment button

Actual result: Nothing happens (or keyboard closes, depending on the state)
Expected result: The emoji or attachment menu should open (when pressing those buttons), or I should go back to the main conversation list (when pressing the Android back button).

Screenshots

Well nothing really happens

Device info

Device: Nokia 6.1
Android version: 10 (unrooted)
Signal version: 4.74.1 (yes, debug)

Link to debug log

https://debuglogs.org/b0e47c44a612f1b4ecab000134b1b07fe0caa38a407a8df9b620d0e086704863

Source

RensOliemans

👍7

Most helpful comment

We've finally been able to repro this issue and will have a fix out soon.

cody-signal on 23 Oct 2020

👍9 ❤5

All 20 comments

From the debug logs I see a lot of NoSuchFieldExceptions when calling Landroid/view/View, but I also see the line crime.securesm: Accessing hidden field Landroid/view/View;->mAttachInfo:Landroid/view/View$AttachInfo; (greylist-max-p, reflection, denied) a couple of times.
Not really familiar with Android, but this seems interesting to me.

RensOliemans on 20 Oct 2020

I just updated my Signal version to 4.72.2 but the error still persists.
According new debug log: https://debuglogs.org/782342efb58290966a23ba6e4298aec6386566eeb1f349eced727c6b716209cb

RensOliemans on 20 Oct 2020

Same Problem here:

Device: OnePlus 7Pro
Android version: 10 (unrooted)
Signal Version: 4.72.2

ni720 on 21 Oct 2020

All identical problems here as well. Exact same setup as the poster above.

Update: just upgraded to Signal v4.74.3, and these problems still persist.

siburny on 22 Oct 2020

Identical issue here as well.

OnePlus7Pro
Android 10 (unrooted)
Oxygen OS 10.0.7.GM21BA
Signal Version v4.74.3

id101010 on 22 Oct 2020

I also have the same problem. Back arrow doesn't work and the rest like the others have stated. I am also using Nova Launcher.

OnePlus7Pro
Android 10
Oxygen OS 10.3.4.GM21AA
Signal Version v4.74.3

Kage1 on 22 Oct 2020

Same.

Oneplus 7Pro
Android 10 (unrooted)
Oxygen OS 10.3.4.GM21AA
Signal Version v4.74.3

https://debuglogs.org/efd76a0f236b6fc98089fa10e40f7b1b08c2bbe53500973cc744addd8c3f9d6c

TurboGLH on 22 Oct 2020

Same here, Nokia 4.2, Android 10, Signal 4.74.3.

This is (at least for my use-case) major breakage! Please fix asap …

l3u on 22 Oct 2020

It looks like this issue maybe related to #10105 which will hopefully be fixed in 4.75.

Kage1 on 23 Oct 2020

It looks like this issue maybe related to #10105 which will hopefully be fixed in 4.75.

That ticket does mention this warning, but it's more about log size. Let's see if v4.75 will address this.

siburny on 23 Oct 2020

It seems the issue is that the app is accessing fields that aren't part of the public API.

https://developer.android.com/about/versions/10/non-sdk-q

If I run the ADB command to disable enforcement it starts working again.

It's simply a result of targeting API level 29, which was done in the commit below, about a week ago.

https://github.com/signalapp/Signal-Android/commit/1ec57c080c522e58654037e81613d404d69a874e

EDIT: It seems like the issue is the following method:

https://github.com/signalapp/Signal-Android/blob/6aecb8fbc1aa14691dceef951d959e62d1360460/app/src/main/java/org/thoughtcrime/securesms/components/KeyboardAwareLinearLayout.java#L122

That's the only place I see that field being accessed. It was apparently added to adress the issue below:

https://github.com/signalapp/Signal-Android/issues/3303

blunden on 23 Oct 2020

👍3

@blunden I agree with your diagnosis.

The link lists Landroid/view/View;->mAttachInfo:Landroid/view/View$AttachInfo; # No public alternative under "Non-SDK interfaces that are now blocked in Android 10".

And I can confirm that adb shell settings put global hidden_api_policy 1 (+ reboot) "fixes" the issue for me on Android 10.

It also suggests that the "fix" for #10105 results in the errors being ignored (instead of at least logged) in v4.75.

obfusk on 23 Oct 2020

We've finally been able to repro this issue and will have a fix out soon.

cody-signal on 23 Oct 2020

👍9 ❤5

Came here to report, nice to see I'm not alone and devs are on it! Thanks guys.

tripslip38 on 23 Oct 2020

👍2

Same issue. Nokia 7.2 unrooted. Backed up, uninstalled/reinstalled, restored, issue is the same.
Noted that the Blue popups during the fresh install have the same issue as the + and system back (respond to the click but do not operate). Submitted debug log. Thanks!