Signal-android: Non-Signal stickers can be used to reply

Created on 14 Aug 2020  路  13Comments  路  Source: signalapp/Signal-Android


Bug description

You can reply to a message with a non-signal sticker (like a sticker from Gboard).

Steps to reproduce

  • reply to someone's message
  • use a sticker from your keyboaed

Actual result: Sticker sends as a reply.

Expected result: Sticker should send independently.

Screenshots


Screenshot_20200827-084038~2

Device info


Device: Google Pixel 4
Android version: 10
Signal version: 4.68.8

Link to debug log

Most helpful comment

Notably the other platforms also don't render these well. Not knowing the best way to render quotes above stickers was the original reason we decided to delay this (although in classic fashion, it's sort of been forgotten about), so I should look at preventing this scenario that's happening. I'll also poke our designers to schedule some time to think about how we want stickers+quotes to look :)

All 13 comments

It's an expected behavior.

I'm aware, but this is an example of the sticker actually being used to reply and it shouldn't as you mentioned.

Actual result: Sticker sends as a reply.

Expected result: Sticker should send independently.

My bad. Sorry.

My bad. Sorry.

All good! Thank you for linking the thread for others to look at if they are confused 馃憤

Do you mean that Signal stickers cannot be used to reply ? Because this seems to be working as it is supposed to

Do you mean that Signal stickers cannot be used to reply ? Because this seems to be working as it is supposed to

Stickers in general should never be sent as a reply, they are always an independent message. They introduced the ability to send Non-Signal stickers (for example: stickers from gboard, memoji etc.) but they can be used to reply. This seems to be unexpected behavior.

My screenshot shows a reply. I just tested it again in 4.69.6 and it still occurs (only with non-signal stickers).
Screenshot_20200827-084038~2

For comparison to Signal stickers, screenshot shows: I had the "reply" open & selected a sticker from there. The sticker sent immediately without being shown as a "reply". This functionality is different from what @Tursko screenshot shows when using non-signal stickers

Capture+_2020-09-21-21-36-04

For me it's a nonsense restriction, if we can use other stickers to reply and it doesn't cause any kind of problem why we can't use the Signal ones?

@Edu4rdSHL, Personally, I agree. But I think that discussion belongs on the community forum, whereas this issue notes the inconsistency... (which might also belong on the community forum, depending whether you call it a "bug" or a "design flaw"? Idk though). There is already a feature request from Apr 2, 2020 at https://community.signalusers.org/t/send-stickers-as-a-reply-to-a-quoted-message/12919

For me it's a nonsense restriction, if we can use other stickers to reply and it doesn't cause any kind of problem why we can't use the Signal ones?

Sending stickers as a reply would be a feature request. But sending a 'non-signal' sticker is unexpected behavior and has formatting bugs.

Where are the "formatting bugs", can you give an example? I see that they're sent perfectly.

Here you go. Look how the reply bubble is rendered.
Screenshot_20200922-230448~2

Screenshot_20200922-230523~2

Notably the other platforms also don't render these well. Not knowing the best way to render quotes above stickers was the original reason we decided to delay this (although in classic fashion, it's sort of been forgotten about), so I should look at preventing this scenario that's happening. I'll also poke our designers to schedule some time to think about how we want stickers+quotes to look :)

Was this page helpful?
0 / 5 - 0 ratings