Signal-android: "Create Alphanumeric PIN" not colored properly in dark theme.

[iamjodiann]

• [x] I have searched open and closed issues for duplicates
• [x] I am submitting a bug report for existing functionality that does not work as intended
• [x] I have read https://github.com/signalapp/Signal-Android/wiki/Submitting-useful-bug-reports
• [x] This isn't a feature request or a discussion topic

---

Bug description

On pin creation there's text saying "CREATE ALPHANUMERIC PIN" but other text says "Pin must be at least 4 digits". Also, when either prompted to create a pin or input pin only the number keyboard displays even though on creation it says the pin can be alphanumeric. It's not clear which is correct (I'm assuming only numbers are allowed).

Steps to reproduce

Create a new pin via the settings menu.

Actual result: Misleading text is displayed
Expected result: Either remove "CREATE ALPHANUMERIC PIN" or make the full keyboard display when entering your pin.

Screenshots

Device info

Device: Google Pixel 3
Android version: 10
Signal version: 4.59.9

Link to debug log

[eike-fokken]

On my device i can tap on "create alpha-numeric pin" to get an an alpha-numeric keyboard. Have you tried that?

[iamjodiann]

On my device i can tap on "create alpha-numeric pin" to get an an alpha-numeric keyboard. Have you tried that?

I didn't try that, it wasn't obvious to me that that was a button. I thought it was just text. Maybe that's the real issue?

[igor2x]

This looks like a defect in Dark Theme. White Theme has "create alpha-numeric pin" string in blue colour to be obvious that it can be tapped, but Dark Theme uses white colour. As seen from bellow screens "Learn more" links are blue in both themes, so should it be "create alpha-numeric pin".

[greyson-signal]

I'll update the title to reflect the problem is a theming issue.

[Sgn-32]

The theming issue affects the two buttons
-'android:id="@+id/kbs_lock_keyboard_toggle"'
-'android:id="@+id/pin_restore_keyboard_toggle"'

The specific color 'android:textColor="@color/core_ultramarine"' is missing in the definition.

[AyusPokhriyal-18]

yeah, i saw this yesterday. Already done this)

[AyusPokhriyal-18]

guyz, i have solved this problem. But, in pull request section, its showing gradle problem. can anyone plz helpme out why its happening

[alan-signal]

You want to back out the last two commits, do not merge master if you need to rebase, do that instead. And do not delete build.gradle, need that!

By the way it is much easier to discuss a PR on the PR itself.

[AyusPokhriyal-18]

Sorry, it's just a week, I started github. And thanks for helping)

On Fri, 22 May, 2020, 2:38 am Alan Evans, [e-mail] wrote:

You want to back out the last two commits, do not merge master if you need
to rebase, do that instead. And do not delete build.gradle, need that!

By the way it is much easier to discuss a PR on the PR itself.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/signalapp/Signal-Android/issues/9623#issuecomment-632346795,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APPHRVNHE4AS77K6FVGOH6LRSWJ47ANCNFSM4NADD54Q
.

[vallividhya]

Does this issue still need help?

[AyusPokhriyal-18]

No, thank you)

On Tue, 2 Jun, 2020, 4:49 am vallividhya, [e-mail] wrote:

Does this issue still need help?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/signalapp/Signal-Android/issues/9623#issuecomment-637175982,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APPHRVLYDDK5RTJSVID3VALRUQZP7ANCNFSM4NADD54Q
.

[fumiakiy]

I think this issue was solved by this commit.

I don't see the issue any more in the build from the master.

[cody-signal]

Thanks @fumiakiy, can confirm that commit should fix the issue.