Signal-android: [Feature Request] Swipe images
I noticed that in a conversation with several images (or media files in general) I have to click each one to view and then return to the conversation list to view the next.
I think it would be more comfortable for the user to be able to swipe (left/right) between all media items sent in this conversation, similar to the Gallery app.
JavaJens
All 14 comments
it's a great idea, would go wonderfully with a media view for conversations
mcginty
on 17 Jan 2015
Threema has a dedicated menu entry in every conversation called Media Gallery. While JavaJens's idea's plus is you don't have to leave the conversation view to see pictures, Threema's is that it keeps received pictures handy. Imagine you raceived a photo or video frome someone 100 entries in the past; you need quite a loot of swiping up to find it.
Maybe a combination of both ideas?
bungabunga
on 17 Jan 2015
@bungabunga @JavaJens what about a solution similar to WhatsApp then? In WhatsApp there is a "gallery" in every conversation with all pictures sorted by date. If you select an image you can still swipe left/right to the previous/next image.
I'd like to see something like that in the future, too! It would be a handy function :+1:
Mihahn
on 17 Jan 2015
I don't know how WhatsApp does it, but this sounds like what @mcginty said with the media view I assume
JavaJens
on 17 Jan 2015
This is what it looks like:
Mihahn
on 17 Jan 2015
@mcginty was very quick and implemented the media view in #2367
It shows all images within a conversation in one view. Swipe is not implemented yet, but I am sure this will be fairly easy now...
JavaJens
on 20 Jan 2015
+1 would be great if implemented!
bbinoy
on 20 Dec 2015
@bbinoy Please don't post in issues unless you have new information to add, thanks
moxie0
on 20 Dec 2015
I am working on this.
FeuRenard
on 3 Oct 2016
The feature is implemented, but I have to test it extensively before opening a PR. You can help by trying out this branch.
Currently there seems to be a memory leak. This causes images after 20+ swipes to one side not to load because of java.lang.OutOfMemory.
EDIT_2016-10-16: The only remaining problem I see at the moment is releasing memory after leaving MediaPreviewActivity.
FeuRenard
on 15 Oct 2016
@FeuRenard
What is the actual status of this issue?
And if there is any pull request, i don't find it.
MartinX3
on 20 Jan 2017
PR: #5801
Status: #5941 should be implemented before or at the same time. The PR itself needs some adaptation. I may have time for that in roughly a month, but I can't promise anything.
FeuRenard
on 20 Jan 2017
Thank you for the fast response :)
And thank you very much for your hard work!
MartinX3
on 20 Jan 2017
Current status of my work: https://github.com/FeuRenard/Signal-Android/commits/media-swipe_draft
I'll have to crack this feature up to some easy to review commits or PRs. Other than that there isn't that much work remaining.
FeuRenard
on 18 Apr 2017
Related issues
nxfifteen
路
3Comments
j3fffff
路
3Comments
Wikinaut
路
3Comments
Dyras
路
3Comments
donjoe0
路
3Comments
Most helpful comment
I am working on this.