Signal-android: Auto-updating APK only works with WiFi / WLAN

Created on 2 Jul 2019  路  7Comments  路  Source: signalapp/Signal-Android


Bug description

Signal should offer updates, no matter what connection (WiFi, Mobile Data, LAN) to the Internet exists. Currently the APK updater only updates if a Wifi connection exists.

Similar issues:

Steps to reproduce

  • Check latest.json to be sure, that is a newer version available.
  • Wait for maximal 24 hours to be prompted for the update.

Actual result:

  • If I am connected to WiFi, the update will be offered.
  • If I am connected to mobile data I do not get an update.

Expected result:

  • I would like to have the possibility that an APK update is also offered with mobile data or LAN (USB2LAN adapter).

Device info


Device: Fairphone 2 (FP2)
Android version: 8.1.0
Signal version: 4.41.5

Link to debug log

The updater job seems to be limited to Wifi networks: UpdateApkJob.java#L145

Most helpful comment

I would agree it is a mistake to assume people will always be able to get on to WiFi. (If you could elaborate on your use case on the community site it would be enlightening, i.e. why you are never on a WiFi connection). And it is also a mistake to assume WiFi is unmetered (and I'm assuming the original intention was to prevent large downloads over metered connections).

But I think it is possible for something to be both a mistake/error/oversight and at the same time not be a bug. The only bug in this area currently is that it doesn't work for everyone.

We just need to discuss it first to find a change that would work for everyone.

All 7 comments

The WiFi restriction is deliberate as you point out.

downloadRequest.setAllowedNetworkTypes(DownloadManager.Request.NETWORK_WIFI);

Which means this is not a bug but working as intended.

Please discuss feature requests on the community site: https://community.signalusers.org/

If this is intended than it seems that it doesn't work on my pixel 3. I have the website version installed on my work profile and it updates itself without ever being connected to WiFi.

@westonal For me this is a mistake and not a feature. Users who don't have WiFi at home will never get updates via the APK version - therefore not usable.

How do I know it was intended? If everything in the source code is intended, then there would be no errors in the code according to this definition.

If it helps, I will post the same text in the https://community.signalusers.org forum.

Added this also to the forum.

@micressor It's working as intended, so not a mistake or a bug. It's a feature you would like to have, thus a feature request. There are plenty of locations with free WiFi, so unless you're unable to leave your home it's really not a major problem.

I would agree it is a mistake to assume people will always be able to get on to WiFi. (If you could elaborate on your use case on the community site it would be enlightening, i.e. why you are never on a WiFi connection). And it is also a mistake to assume WiFi is unmetered (and I'm assuming the original intention was to prevent large downloads over metered connections).

But I think it is possible for something to be both a mistake/error/oversight and at the same time not be a bug. The only bug in this area currently is that it doesn't work for everyone.

We just need to discuss it first to find a change that would work for everyone.

Was this page helpful?
0 / 5 - 0 ratings