Signal-android: Poor color contrast in information banner of "submit debug log" view.

Created on 1 May 2019  路  8Comments  路  Source: signalapp/Signal-Android


Bug description

Actual result: Words are difficult to read, especially when the phone dims during night time.
Expected result: Decent amount of contrast, even if the phone adjusts the color temperature during nightly hours.

Screenshots

signal-attachment-2019-05-01-005304

Most helpful comment

Thanks, are you aware of the Accessibility Scanner app from Google?

image

It agrees on this item.

These kind of reports would be useful to help choose where to spend the effort first.

All 8 comments

Do note that the text is quite readable here, but not so much on a small and dimmed phone screen.

Thanks, are you aware of the Accessibility Scanner app from Google?

image

It agrees on this item.

These kind of reports would be useful to help choose where to spend the effort first.

These kind of reports would be useful

Why would you need such report? I just told you the contrast is insufficuent, didn't need this tool for it. Obviously the text should not be brown, or at least darker.

But glad it agrees with me.

Next time I see an issue like this I'll take that extra effort, didn't think it was important.

Why would you need such report? I just told you the contrast is insufficuent, didn't need this tool for it. Obviously the text should not be brown, or at least darker.

This tool shows mathematically that there's too little contrast, as opposed to someone saying there is. It helps avoid personal bias. Also, please remember to be polite.

I think it is impolite to question whether I am personally biased while I already provided a screenshot. Asking me to install and make use of a tool to double check something obvious just so there is mathematical proof, is a lot more effort on my side than it would be for you to look at the screenshot. By filing this ticket I already helped you "choose where to spend the first effort". If I file the ticket I think there is an issue.

But sure, if you prefer this method I will use that next time. It is an interesting tool and I am glad you pointed it out to me. I just question why it is important to include when a screenshot already shows the issue and it is visually obvious. A screenshot is already proof of the issue.

Excuse my accidental closing this issue, lets keep it open until it is fixed.

We appreciate the report :) Alan was just suggesting a tool that can be used in the future. Instead of having to make comments like:

Do note that the text is quite readable here, but not so much on a small and dimmed phone screen

you can post the screenshot like Alan did, showing the bad contrast ratio. And to be clear, it was given as a suggestion, not a requirement.

Also wanted to clear up that when I said the tool helps avoid personal bias, I wasn't trying to disqualify your issue saying that you are biased, I was just answering your question of "Why would you need such report?" in the general case.

Thanks!

There have been some changes in the "submit debug log"area prior to some versions.
Didn't find the exact version and the commit. But should be solved.

I firgot to check if this issus had been marked solved. Let's not bother with finding the commit, it's solved.

Was this page helpful?
0 / 5 - 0 ratings