Signal-android: sms delivery report: show received time in message details

[doits]

when a sms delivery report is received, the time the other user received the message (afaik the done date) should be saved and it should be possible to view it in message details. This way one could see when the other user received the message (not only that is was received).

edit: if someone can give me a hint where to look/start in the code to implement this, I'd try to make a pull request (but I just glanced through the code and cannot find a starting point ... maybe it's simply too late already ;-))

[tinloaf]

That sounds reasonable, but since the receipt code is going to change a lot over the next days (moxie is bringing receipts to the push messages, see according pull request), it's probably not wise to start messing with it now. ;) Would be reasonable to implement this while being at it...

[devurandom]

+1, this is a useful feature of the default SMS application.

[grinapo]

I'd expand a bit: it is usually required to register

• creation time (when the message was written)
• send time (since push can hold message pending for extended periods when there's no net connection)
• receipt time (since it's usually different from both above eg. the SMS provider hold delivery pending)

In my daily experience this information is necessary to be able to know what happened (post mortem), and can help preventing heated debates about when the message was written, sent or received. :-)

[rhodey]

related #2055

[m42i]

Not sure if this is the right issue, because it's about showing a time. The code for showing a double check mark seems to be there. Commenting out three lines shows the icon. (See: SmsSendJob.java:139 )

Though I guess for a proper implementation a preference options should be created.

Is there a conclusion on the security aspects mentioned in #2255?
Would it be enough to warn the user of the possibility the SMS delivery report could be forged?
How is #2055 related?

[GfEW]

+1 Any news to this?
Stock messaging app provides confirmation times, but since outgoing messages are not listed there when Signal is the standard messaging app, that doesn't help.

The forgery argument is moot. AFAIK, the entire SMS protocol is forgeable, including authenticity, content, sent time, delivery status, delivery time. If we decide to use it nevertheless (and we might want to warn the user about the risk), there's no reason to conceal SMS delivery times.

Please, provide delivery confirmation times within Signal.

[moxie0]

@GfEW Please don't post things like "+1" in issues, it'll only make us less likely to work on it.

[GfEW]

Thanks, got it. Main point is about forgery. I'll omit the '+1' primer in the future.

[grinapo]

@moxie0 Without the intention of lessening the probability of anyone's working on this issue, would it be possible to actually record and show all the time data Signal was made to be aware of? At least the receive time of a delivery report is pretty obvious, and it's handled by the code putting the second tick on the messages, so it seems to be only a question to store it in the database, and show it when asked. (I don't have the possible content of the delivery report handy so I cannot tell whether it contains the real delivery time, too. If it would do then it should be recorded, too.)

I hope asking about biannually isn't too rapid, considering the complexity of the problem, which is probably close to "trivial", and the age of the issue, which is almost 3 years now. (And I accept the blame for not taking the time to familiarise with java and doing it by myself.)

[micressor]

+1

[AdamGladkowski]

+1, I'm really surprised that signal is missing sth so simple and yet so useful as plain text message delivery notifications :(
please add it :)

[automated-signal]

GitHub Issue Cleanup:
See #7598 for more information.