Signal-android: [i18n] Strings related to disappearing message time

Created on 11 Mar 2018  Â·  1Comment  Â·  Source: signalapp/Signal-Android

I have:


Bug description

Here's another one I've found on Transifex in the comments section. The comment below has been made on the first string only, but I guess the two other strings should be affected as well.

I agree that systematically, placeholders within a sentence that can represent both, numbers and words, are probably not the best idea, as they can lead to trouble in many languages.

Strings:
Key: MessageRecord_you_set_disappearing_message_time_to_s
Content: "You set disappearing message time to 1%1$s."

Key: MessageRecord_s_set_disappearing_message_time_to_s
Content: "1%1$s set disappearing message time to 2%2$s."

Key: ThreadRecord_disappearing_message_time_updated_to_s
Content: "Disappearing message time set to 1%s"

Translator's comment:
"With the most natural translation for the times, this string looks very odd when turning the time off, reads like "You set messages to disappear after Off" – could we please have two separate strings? One for Off and one for some specific time?"

help wanted i18n

Most helpful comment

@greyson-signal I just rebased PR #7734 which will fix this issue.

>All comments

@greyson-signal I just rebased PR #7734 which will fix this issue.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jult picture jult  Â·  3Comments

Wikinaut picture Wikinaut  Â·  3Comments

vvug picture vvug  Â·  3Comments

5boro picture 5boro  Â·  3Comments

hiredgunhouse picture hiredgunhouse  Â·  3Comments