I have:
Here's another one I've found on Transifex in the comments section. The comment below has been made on the first string only, but I guess the two other strings should be affected as well.
I agree that systematically, placeholders within a sentence that can represent both, numbers and words, are probably not the best idea, as they can lead to trouble in many languages.
Strings:
Key: MessageRecord_you_set_disappearing_message_time_to_s
Content: "You set disappearing message time to 1%1$s."
Key: MessageRecord_s_set_disappearing_message_time_to_s
Content: "1%1$s set disappearing message time to 2%2$s."
Key: ThreadRecord_disappearing_message_time_updated_to_s
Content: "Disappearing message time set to 1%s"
Translator's comment:
"With the most natural translation for the times, this string looks very odd when turning the time off, reads like "You set messages to disappear after Off" – could we please have two separate strings? One for Off and one for some specific time?"
@greyson-signal I just rebased PR #7734 which will fix this issue.
Most helpful comment
@greyson-signal I just rebased PR #7734 which will fix this issue.