Signal-android: Show first-letter-avatar in recipient preferences

[FeuRenard]

I have:

• [x] searched open and closed issues for duplicates
• [x] read https://github.com/WhisperSystems/Signal-Android/wiki/Submitting-useful-bug-reports

---

Bug description

The avatar for contacts in my address book without any picture changes from first-letter-avatar to some default avatar when I switch from/to recipient preferences.
Maybe this is related to #7022.

Steps to reproduce

• select a conversation with a user that has no profile picture and is in my contacts with a name
• tap the conversation header

Actual result: In RecipientPreferenceActivity the first-letter-avatar is replaced by "some person" avatar.
Expected result: RecipientPreferenceActivity shows the first-letter-avatar.

Screenshots

Device info

Device: Fairphone 2
Android version: 6.0.1
Signal version: 4.11.0

[moxie0]

Hmm, this is intentional. A big "F" right there would look pretty weird, right?

[FeuRenard]

It just feels inconsistent switching between conversation and recipient preferences.

[moxie0]

How do you think it should work instead?

[FeuRenard]

It got better with 4.11.1 I think. Now the slightly more modern default person is used:

I looked in the Android 6 contacts app. There a list of contacts is shown with first-letter-avatars. Clicking on an entry shows this:

Maybe we could mimic this look: contact color as background and white icon on top.

Final remark: Note the gap between contact picture and conversation settings (in screenshot "Unterhaltungseinstellungen"). The conversation has no shared media. So this segment is missing and conversation settings segment is first. It should spare the top margin in this case.

[rainerzufall]

please also note, that there now 3 different visualisations for a group avatar:

white on grey in conversations overview:

grey on white in group conversation:

grey on grey in group conversation settings: