Signal-android: Android 8 crash when opening the attachment drawer a second time

[riyapenn]

I have:

• [X] searched open and closed issues for duplicates
• [X] read https://github.com/WhisperSystems/Signal-Android/wiki/Submitting-useful-bug-reports

---

Bug description

Crash on Android Oreo after attempting to attach or attaching a picture directly from the message thread. Typically crashes on second tap of the attachment icon.

Steps to reproduce

• Open a conversation
• Tap the attachment icon
• Close the attachment drawer
• Tap the attachment icon a second time

Actual result: Attachment drawer is partially displayed & Signal crashes
Expected result: Display drawer & not crash

Screenshots

Device info

Device: LGE Nexus 5X
Android version: 8.0.0
Signal version: 4.9.9

Link to debug log

https://gist.github.com/472ca31f484bc4e908b5beb5e950ce15

[moxie0]

Is this an official build or an aftermarket ROM update? The crash is a segfault in OS code.

[riyapenn]

Official build for Android 8.0.0. Prior to this, the device was running official Android O betas. All updates have been done OTA.

[RiseT]

Same here.
Debug log: https://gist.github.com/anonymous/55715ded01ef69d58579a638f0cbf20d

Like here, Nexus 5X with offical Android 8.0.0

[moxie0]

This really looks like an Android 8 bug to me. I can't think of anything we could do that should cause a segfault in the renderer. Maybe there's something we can do to work around it, but I still don't have Android 8 on a physical device.

[RiseT]

Could temporarily (until the Android bug is fixed) disabling that drawer animation help? At least optically, it looks like the issue arises during that animation.

Is there a simple parameter in the code that I can change in order the set the drawer animation to "no animation" in order to test this?

[Le1b1]

Here is mine: https://gist.github.com/adb8f2787a71f842d4d8d00253eca92c

The number of taps on the icon to crash Signal differs between 1 - 3.

[Le1b1]

I don't know why, but if I turn the 'energy safer' on in system settings, Signal doesn't crash anymore.

[RiseT]

I don't know why, but if I turn the 'energy safer' on in system settings, Signal doesn't crash anymore.

Confirmed with v4.10.7.

[veeti]

It's unfortunate visually, but removing elevation on attachment_type_selector resolves this on Nexus 5X.

[RiseT]

Has this been fixed (...by https://github.com/WhisperSystems/Signal-Android/commit/74779adc3436542ef2a9b1a89fc45f645720dc31 perhaps)? I'm currently unable to reproduce this on v4.10.11.

Edit: FYI - I've installed the September update for Android 8 recently.

[riyapenn]

This is still occurring but less frequently on 4.10.12 for the original report.
Log: https://gist.github.com/a24d2a8f37ea97371f822b40104f4f70

[igor2x]

I also have this problem on LG Nexus 5X using Android 8 and Signal 4.10.12. It is interesting that crash does not happen every time I tap on attachment icon. First time tap on attachment does not crashes it. It is required to tap 2 times (and cancel between), sometimes more.

When problem appears it appears when attachments are only half screen displayed:

Crash window:

I clicked on "Send feedback" and made print screens of screen:

But what it is interesting it looks like only attachment component crashes and Signal works normally. Actually when crash appears and I tap on "Close app" only this question dialog closes, but Signal main window (as seen on second image) gets displayed, but Signal is working fine. It may be that Signal itself does not crashes, but only some Android file attachment component or something.

[florianprischl]

I can confirm this issue. I have tried it several times now and it already happens on the first tap of the attachment button.

Steps to reproduce

1. Open conversation
2. Tap attachment icon
3. Actual result: Attachment drawer partially displayed, Signal crashes
4. Expected result: Display drawer, do not crash

The bug does not occur in Energy Saver Mode, as mentioned by @Le1b1 and @RiseT.

Screenshots (scaled down to 225x400 px)

Device info
Device: LGE Nexus 5X
Android version: 8.0.0, patch level 5 September 2017, official build OPR4.170623.006 (I flashed 8, it's not an OTA from Android 7)
Signal version: 4.10.12

Debug log
https://gist.github.com/anonymous/346ab604f29d7ebab22a14ed8bb3eb77

[RiseT]

Mh. My device is a Nexus 5X with Android 8.0.0 & (now) patch level 10/2017 (same for 09/2017) as well, but the issue seems fixed for me. Strange.

Edit: Don't know if this is of any importance, but since the last time I was affected by this issue, I've done - because of other reasons - a couple of re-installs of Signal.

[florianprischl]

Update: The crash does not occur if the attachment button is tapped while the cursor is in the message input field, i.e. when the keyboard (in my case, Gboard by Google) is open. For reference, in that situation the drawer opens to its bottom instead of its top. See the following screenshots:

[claptopus]

Same issue. Pixel XL on 8.0. If you tap attach when the keyboard is open it will crash back to the messages window. If you tap attach without the keyboard open it works normally.

[florianprischl]

The issue no longer appears for me.
Device info
Device: LGE Nexus 5X
Android version: 8.1.0, patch level 5 December 2017, official build OPM1.171019.011
Signal version: 4.13.6