Signal-android: Text entered into quick reply toast is lost when another message comes in

[deutrino]

• [x] searched open and closed issues for duplicates
• [x] read https://github.com/WhisperSystems/Signal-Android/wiki/Submitting-useful-bug-reports

Bug description

When a message comes in and a toast pops up with the ability to mark read or quickly reply, if I've entered some text and another message comes in, the next message's toast obliterates the one I was typing. No draft is saved.

Steps to reproduce

• Be using an app that's not Signal
• Receive a message
• Start typing a reply in the toast box
• Receive another message (in my case from the same sender, I'm not positive a different sender will cause this)

Actual result: The 2nd message's toast pops up over the first one, and the message being entered into the first toast disappears.
Expected result: Preferably the 2nd message would be queued (or perhaps extend the toast vertically, if that's an option?), or at least a draft would be saved. Either of these options are not the greatest UX though.

Device info

Device: I don't like sharing this info publically
Android version: 7.1.2 (LineageOS 14.1)
Signal version: 4.6.1

Link to debug log

I don't currently have one - time crunch this morning - and not sure it will be useful, but if so, I will set up with a friend to induce this bug later today or tomorrow.

[ghost]

probably duplicate of https://github.com/WhisperSystems/Signal-Android/issues/4729

[Dyras]

@p4nci I don't think so, the issue you link mentions the text eventually comes back. In this issue however, it never does.

Edit: I can confirm that receiving a message from another sender than the one you are replying to also causes the message to vanish

[ghost]

@Dyras can only partially confirm

1. receive message
2. tap reply and write something
3. receive another message (=> draft disappears)
4. retap reply => draft reappears, but not within Signal itself

[FeuRenard]

Just to make it clear for everybody: you aren't talking about Signal's own implementation of a quick reply window (first screenshot) but about the quick reply function introduced with Nougat (second screenshot).

Screenshots

quick reply < Android 7

quick reply >= Android 7

[deutrino]

I am referring to the Android 7 one, yes.

[FeuRenard]

It sounds like this issue is related to #6050 and would be improved by implementing the requested feature.

[dcherian]

Dupe of #6042 ? and both will be fixed if #6050 is addressed?

[deutrino]

I think this is a dupe of #6042, although more discussion has accrued in this issue now.

[deutrino]

I wanted to clarify when the text is completely lost.

• Receive message from a contact and hit reply in the toast notification
• Start typing into the text box within the toast
• Receive message from a different contact which pops over the toast
• Typed text is now irretrievably lost

If you receive a message from the same contact, it pops over the toast but the text can be salvaged by hitting 'reply' and loading the full app's reply UI.

It occurs to me that this bug could perhaps be avoided quite simply by never having a toast pop over one that already exists, or that the user is currently interacting with.

[automated-signal]

GitHub Issue Cleanup:
See #7598 for more information.