Signal-android: Show an inline map instead of a Google Maps link
I have:
- [x] searched open and closed issues for duplicates
- [x] read https://github.com/WhisperSystems/Signal-Android/wiki/Submitting-useful-bug-reports
It'd be nice if, instead of showing a Google Maps link, Signal displayed a map inline. This would improve the UX for location "attachments" quite a bit, IMO.
strugee
All 11 comments
OpenStreetMap would be an ideal match for most locations
piratenpanda
on 11 Mar 2017
Related: #5042
Be-ing
on 12 Mar 2017
It'd be nice if, instead of showing a Google Maps link, Signal displayed a map inline.
I'm sorry if I don't understand your request correctly, but doesn't Signal already do both (i.e. send a link together with a map)?
haffenloher
on 13 Mar 2017
@haffenloher no, I'm pretty sure it doesn't - that's the point of this issue. I'll double-check though.
strugee
on 13 Mar 2017
Huh, looks like I was wrong. For some reason I thought this didn't work.
strugee
on 13 Mar 2017
Though on second thought, this seems to just be an image. It'd be nice if the map was actually interactive and let you open a map view by tapping on it, without actually leaving the app.
strugee
on 13 Mar 2017
@strugee There is a strong privacy reason for sending an image. Sending an "interactive map" means sending a location and having Signal (or an external library) query a server to load the map, leaking the exchanged location.
You could think of a "load location" button that prevents the map from auto-loading, but this is basically how it works now, where the static image is the button.
paride
on 13 Mar 2017
@paride oh, that's a great point. So I see two alternatives here:
- Keep the existing behavior
- Use offline OpenStreetMap tiles, if available
I'll let Moxie or one of the other developers make the final call, but I'm betting on option 1.
strugee
on 13 Mar 2017
This was the commit message of the commit which introduced location sharing:
Start with encoding as a simple image thumbnail for compatibility with MMS and iOS.
Source: bcf95e50aa38cae2dfe640ea1a1e26cbaa3a84b7
So I would say there's something on the roadmap.
FeuRenard
on 16 Mar 2017
I think the idea is to sync up Android and iOS's attachment capability and then add more to both.
jeremymasters
on 16 Mar 2017
GitHub Issue Cleanup:
See #7598 for more information.
automated-signal
on 3 Apr 2018
Related issues
ilikenwf
路
3Comments
McLoo
路
3Comments
kwlg
路
3Comments
FeuRenard
路
3Comments
jult
路
3Comments
Most helpful comment
@strugee There is a strong privacy reason for sending an image. Sending an "interactive map" means sending a location and having Signal (or an external library) query a server to load the map, leaking the exchanged location.
You could think of a "load location" button that prevents the map from auto-loading, but this is basically how it works now, where the static image is the button.