Signal-android: URLs in messages fail to include the trailing slash

Created on 15 Feb 2017  路  5Comments  路  Source: signalapp/Signal-Android

I have:


Bug description

URLs in messages fail to include the trailing slash. (In contrast, Signal Desktop does include the slash.)

Steps to reproduce

  • Send someone the message Test link: https://www.example.com/foo/bar/ Yay!
  • look at the link; click the link
  • notice that Signal treated the trailing slash as not part of the link

Actual result: Signal treated the trailing slash as not part of the link
Expected result: Signal should underline the trailing slash and include it in the URL when you click it

Screenshots


screenshot_20170215-095051
screenshot_20170215-095224

Device info


Device: Google Nexus 5X
Android version: 7.0
Signal version: 3.28.4

Link to debug log

Most helpful comment

Had a look at this. It does in fact look like a duplicate of #6019 to me.

It is notable that this only happens if the message contains some text after the link:

screenshot_20170226-133612

@idupree commented on how one could fix this manually here, but I do not think that this is a critical issue (as the link still works) and believe that this is something that should be fixed in Linkify instead of adding workaround code to every app out there using it (remember, it's part of Android).

All 5 comments

Duplicate of #6019? (cc @nikwen)

@2-4601 Will check that when I have a few minutes.

Had a look at this. It does in fact look like a duplicate of #6019 to me.

It is notable that this only happens if the message contains some text after the link:

screenshot_20170226-133612

@idupree commented on how one could fix this manually here, but I do not think that this is a critical issue (as the link still works) and believe that this is something that should be fixed in Linkify instead of adding workaround code to every app out there using it (remember, it's part of Android).

To be clear, I noticed this because a site had a page which was broken without the trailing slash. (This isn't very good web practice, but it happens sometimes.) I don't disagree about this issue being noncritical.

Closing as duplicate of #6019.

Was this page helpful?
0 / 5 - 0 ratings