Signal-android: 3.25.0 introduced probably unintended UI changes
I have:
- [x] searched open and closed issues for duplicates
- [x] read https://github.com/WhisperSystems/Signal-Android/wiki/Submitting-useful-bug-reports
Bug description
6308e64 introduced this, let the screenshots speak for themselves.
Besides the changes you can see in the screenshots the animation when you send a message and the new bubble appears changed slightly, I think.
Screenshots
A wild Signal icon appears in...
... NewConversationActivity
... RecipientPreferenceActivity
... InviteActivity
... GiphyActivity
Mind the gap between back arrow and recipient, before 6308e64
After 6308e64
FeuRenard
All 21 comments
I actually like the last change...
Dyras
on 17 Dec 2016
That's what we get for updating. Thanks!
moxie0
on 17 Dec 2016
the animation when you send a message and the new bubble appears changed slightly, I think.
Yeah, noticed that too. It's weird but I guess one gets used to it quickly.
2-4601
on 18 Dec 2016
I got rid of the surprise app icon everywhere. The padding change is apparently to enforce the material standards. I think it's a waste of space on the contact search/selection activities so I disabled it there, but left it everywhere else.
That animation change is terrible! Anyone want to look into it?
moxie0
on 18 Dec 2016
It looks like the ItemAnimator's "add" animation is getting canceled, so it displays immediately before the move animation for the items above it is complete. There are many changes to the data set in quick succession (pending, sent, delivered), and it seems that those changes are canceling the animation. Not sure why.
moxie0
on 18 Dec 2016
I've reverted the support library updates. I think we'll have to stop calling notifyDataSetChanged() in order to update them, which is kind of a big change, so I'm going to delay making it for now.
moxie0
on 19 Dec 2016
Is it just me, or are a lot of these problems back in 3.26.0? I think this issue should be re opened.
nrizzio
on 7 Jan 2017
I spotted the wild Signal icon in GIF search and the additional space in several activities' action bars.
FeuRenard
on 7 Jan 2017
@nrizzio what are you seeing other than the signal icon in gif search?
moxie0
on 7 Jan 2017
@moxie0 the extra padding between the back arrow and recipient in a conversation thread is back, along with the awkward animation when a new message is sent/received.
nrizzio
on 7 Jan 2017
@nrizzio That extra padding is "intentional" now. You should be seeing the normal animation, though. What kind of conversation is it?
moxie0
on 7 Jan 2017
@moxie0 It's an encrypted Signal conversation. The problem exists in encrypted one-on-one and group chats. But the awkward animation will go away when using unencrypted text transport.
Here is a debug log: https://gist.github.com/6bdeb7312cefccec54619ee07746aab0
nrizzio
on 7 Jan 2017
I see the old animation for Signal messages on Android 5.1.1.
FeuRenard
on 8 Jan 2017
I decided to just remove the conversation item animations. There are some pretty bad recyclerview bugs that I can't work around, and it actually feels faster this way.
moxie0
on 8 Jan 2017
I have upgraded from 3.24.0 to ~the current master branch~ b7d4294314a2fca23821d56077ae382e8f90bfdb and i am pretty sure opening threads takes a little bit (something between 100 and 500ms i guess) longer.
I have held two signal instances on the same phone (same model, same OS version, same gapps) next to each other and opened the same thread multiple times: the 3.24.0 build has beaten the current master every time.
If i close a thread, press the home button and press the signal icon on the homescreen (must be homescreen) to open signal again, the next thread is opened significantly faster (i.e. long before the button-press animation finishes).
My local changes should not be related to this particular issue.
Trolldemorted
on 8 Jan 2017
@Trolldemorted if you can reproduce a performance issue please profile it and see where the time is going
moxie0
on 8 Jan 2017
First i will have a look whether it is better after 5804213152b8f6cf6a9bd0225c5e2677ed39a5e2, since this sounds like it could be a recyclerview issue to me. If it is not, i will have a look!
Trolldemorted
on 8 Jan 2017
5804213152b8f6cf6a9bd0225c5e2677ed39a5e2 did not fix it. I played a little around with the android device monitor:
[top: "normal" thread selection", bottom: thread selection using method described above]
As you can see, during the "normal" thread selection we spend ~190ms more in android.view.ViewRootImpl.doTraversal, which would match my estimation of the delay. Any ideas what has caused this?
Trolldemorted
on 9 Jan 2017
@Trolldemorted sounds like a job for git bisect!
moxie0
on 10 Jan 2017
I can confirm that on my Moto G4, opening a thread takes noticeably longer now.
Dyras
on 11 Jan 2017
Bummer, if someone who can reproduce this wants to find the offending commit with git bisect, that'd probably help a bunch. Also let's open a new issue specifically for this performance degradation.
moxie0
on 12 Jan 2017
Related issues
kwlg
路
3Comments
derWalter
路
3Comments
donjoe0
路
3Comments
wesinator
路
3Comments
gmsl360
路
3Comments
Most helpful comment
5804213152b8f6cf6a9bd0225c5e2677ed39a5e2 did not fix it. I played a little around with the android device monitor:
[top: "normal" thread selection", bottom: thread selection using method described above]
As you can see, during the "normal" thread selection we spend ~190ms more in
android.view.ViewRootImpl.doTraversal, which would match my estimation of the delay. Any ideas what has caused this?