Signal-android: ActivityNotFoundException after enabling/disabling Signal as default SMS app

[KarolTrzeszczkowski]

_Edit: Restructured based on the sharp-eyed research by_ @haffenloher

---

Bug description

android.provider.Settings.ACTION_WIRELESS_SETTINGS does not have matching activity in Android FlymeOs and Signal crashes.
According to Android docs the app developer should take it into account that not all Android flavours have this activity:

In some cases, a matching Activity may not exist, so ensure you safeguard against this.

Steps to reproduce

1. Signal is your default SMS app
2. you go to _Settings > SMS and MMS_
3. you touch _SMS Enabled - Touch to change your default SMS app_
4. the system dialog (called _Wireless & networks_ in 5.1 emulator) that Signal tries to open somehow does not exist
   

   Device info

Device: Meizu m2 note,
Android: Flyme OS 4.5.4.2I, Android 5.1
Signal: 3.14.2

Link to debug log

https://gist.github.com/dff65ac6cc0972b854c2

FATAL EXCEPTION: main
Process: org.thoughtcrime.securesms, PID: 24169
android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.settings.WIRELESS_SETTINGS }
    at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:1800)
    at android.app.Instrumentation.execStartActivity(Instrumentation.java:1518)
    at android.app.Activity.startActivityForResult(Activity.java:3852)
[...]

[haffenloher]

Wait, is this tracked somewhere?

FATAL EXCEPTION: main
Process: org.thoughtcrime.securesms, PID: 24169
android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.settings.WIRELESS_SETTINGS }
    at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:1800)
    at android.app.Instrumentation.execStartActivity(Instrumentation.java:1518)
    at android.app.Activity.startActivityForResult(Activity.java:3852)
[...]

I don't think this has anything to do with #5308.
Android docs for android.provider.Settings.ACTION_WIRELESS_SETTINGS say:

In some cases, a matching Activity may not exist, so ensure you safeguard against this.

So we should probably do something about the crash.

[haffenloher]

@2-4601 No, sorry, that wasn't very clear :stuck_out_tongue:
the crash happens when

1. you're on Android 4.4 or later
2. Signal is your default SMS app
3. you go to _Settings > SMS and MMS_
4. you touch _SMS Enabled - Touch to change your default SMS app_
5. the system dialog (called _Wireless & networks_ in my 5.1 emulator) that Signal tries to open somehow does not exist

Edit - just to be clear: I cannot reproduce this myself.

[KarolTrzeszczkowski]

I think it is the case it of Meizu and it's modification of Android flyme os.

[automated-signal]

GitHub Issue Cleanup:
See #7598 for more information.