Sidemenu: Compilation issue when updating my project from 5.0.3 to 6.0.2

Created on 17 Jul 2019  Â·  12Comments  Â·  Source: jonkykong/SideMenu

I have read the guidelines for contributing and I understand

  • [X ] My issue is happening in the latest version of SideMenu (older versions are no longer maintained).
  • [ X] My issue was not solved in the README.
  • [ X] My issue can not be answered on stackoverflow.com.
  • [X ] My issue is not a request for new functionality that I am unwilling to build and contribute with a pull request.
  • [ X] My issue is reproducible in the demo project.

Describe the bug
Once updating to the latest project, I get several compilation errors, listed below under the steps to reproduce.

To Reproduce
Steps to reproduce the behavior:

Errors
-Value of type 'SideMenuManager' has no member 'menuWidth'
-Type 'Any' has no member 'viewSlideInOut'
-Value of type 'SideMenuManager' has no member 'menuAnimationBackgroundColor'
-Value of type 'SideMenuManager' has no member 'menuFadeStatusBar'

My code:
SideMenuManager.default.menuWidth = max(round(min(UIScreen.main.bounds.width, UIScreen.main.bounds.height) * 0.20), 240) // 20% of screen space
SideMenuManager.default.menuPresentMode = .viewSlideInOut
SideMenuManager.default.menuAnimationBackgroundColor = UIColor.white
SideMenuManager.default.menuFadeStatusBar = false

Expected behavior
A migration document or information on how to use these values with the refactor. I spent a long time searching today and couldn't find any documentation on where these values were moved. After manually searching through the code changes, I finally discovered Deprecations.swift that all of these properties are listed in there with a note "This property has been moved to the UISideMenuNavigationController class" with the exception of "menuPresentMode" which has a note that it's been renamed to SideMenuPresentStyle. However, I didn't see these values in UISideMenuNavigationController either.

Screenshots
n/a

Additional context
n/a

Bug - Help Wanted!

Most helpful comment

You want statusBarEndAlpha and presentationStyle.backgroundColor.

All 12 comments

The latest is 6.0.3 (as of this morning!).

The README details how to configure the latest version of SideMenu. Additionally, I have put in deprecation notices on most of the old properties to help with awareness. In short: all of the settings have moved off of SideMenuManager over to UISideMenuNavigationController. Some properties have been renamed -- again, see the README for the details.

I updated my code around 11am this morning and it was 6.0.2. I just updated it again to 6.0.3.

The README is what I've been using and I still haven't figured out where some of the properties went.

In Deprecation.swift, menuPresentMode says it has been renamed to SideMenuPresentStyle but that is actually the type. It has been renamed to presentationStyle and also moved to UISideMenuNavigationController (which isn't mentioned).

I found menuWidth under UISideMenuNavigationController.

Where did menuAnimationBackgroundColor and menuFadeStatusBar go/get renamed to? I have not been able to find any equivalent properties for those in UISideMenuNavigationController.

You want statusBarEndAlpha and presentationStyle.backgroundColor.

Hi what about these property, 'menuAnimationFadeStrength'. What is the renamed property of this one.

SideMenuManager.default.menuPresentMode = .menuSlideIn .                                  'menuPresentMode' is deprecated: This property has been moved to the SideMenuNavigationController class.
SideMenuManager.default.menuWidth = UIScreen.main.bounds.width * 0.80                     'menuWidth' is deprecated: This property has been moved to the SideMenuNavigationController class.
SideMenuManager.default.menuFadeStatusBar = false                                         'menuFadeStatusBar' is deprecated: This property has been moved to the SideMenuNavigationController class.


Unable to find replacement for above line, deprecated message is not very much useful side menu was working perfectly before iOS 13 but in iOS 13 there multiple issue. Side menu is not showing as it was showing prior to iOS 13

Hi Varun,
Thanks for your reply. I implemented SideMenu as the same above way.

On Mon, Feb 3, 2020 at 4:53 PM Varun Naharia notifications@github.com
wrote:

SideMenuManager.default.menuPresentMode = .menuSlideIn . 'menuPresentMode' is deprecated: This property has been moved to the SideMenuNavigationController class.
SideMenuManager.default.menuWidth = UIScreen.main.bounds.width * 0.80 'menuWidth' is deprecated: This property has been moved to the SideMenuNavigationController class.
SideMenuManager.default.menuFadeStatusBar = false 'menuFadeStatusBar' is deprecated: This property has been moved to the SideMenuNavigationController class.

Unable to find replacement for above line, deprecated message is not very
much useful side menu was working perfectly before iOS 13 but in iOS 13
there multiple issue. Side menu is not showing as it was showing prior to
iOS 13

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/jonkykong/SideMenu/issues/502?email_source=notifications&email_token=AIJAOGXTK6KFVNY5OZBBCA3RBAHVZA5CNFSM4IEUKDS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKTXL4Y#issuecomment-581400051,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIJAOGXQ4CLIDCEISWGBHBDRBAHVZANCNFSM4IEUKDSQ
.

--
[image: photo] http://www.qinnovation.ae/

Hilaj Sirajudeen
Developer
[image: photo] +971 56 4564492
[image: photo] +971 4 4548338
[image: photo] Dubai Internet City, Building 16
P.O Box 500539, Dubai UAE

@hilajqinnovation are you saying that you are not getting any issue using SideMenu with Xcode 11.3 and iOS 13 ?

Hi Varun,
I got issues when i run on iOS 13, but I fixed those issues.

On Mon, Feb 3, 2020 at 5:39 PM Varun Naharia notifications@github.com
wrote:

@hilajqinnovation https://github.com/hilajqinnovation are you saying
that you are not getting any issue using SideMenu with Xcode 11.3 and iOS
13 ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jonkykong/SideMenu/issues/502?email_source=notifications&email_token=AIJAOGXR74YLBY4JIA5ELJLRBANBRA5CNFSM4IEUKDS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKT3YKY#issuecomment-581418027,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIJAOGQS4PBH5ENA5N7D7ETRBANBRANCNFSM4IEUKDSQ
.

--
[image: photo] http://www.qinnovation.ae/

Hilaj Sirajudeen
Developer
[image: photo] +971 56 4564492
[image: photo] +971 4 4548338
[image: photo] Dubai Internet City, Building 16
P.O Box 500539, Dubai UAE

@hilajqinnovation Can you please explain me how did you fix this issue ?

Go to the Attribute inspector of the side menu navigation controller
then go down to "presentation" and choose "Over Full Screen".
I Hope it works for you guys as well as it did to me :)

HELLO JONKY KONG I am using your pod in Xcode 11.5 swift 4 . i have implement sidemenunavigation Controller in storyboard and i had made xib class for my next vc how i can present modally the side menu

Kindly Update me ASAP

Was this page helpful?
0 / 5 - 0 ratings

Related issues

nahouto picture nahouto  Â·  4Comments

joebenton picture joebenton  Â·  5Comments

selaysoysal picture selaysoysal  Â·  7Comments

Mohamed-Akl picture Mohamed-Akl  Â·  3Comments

tush010 picture tush010  Â·  3Comments